On Sun, Sep 02, 2001 at 10:01:43AM +0200, Benjamin Bruheim wrote:
Just out of curiousity:
- removeReader(self) + self.stopReading()
That removeReader is _never_ called :) If it were called, the temporary DTP-servers in twisted.ftp would be removed every time I called loseConnection. And it would generate a NameError (I guess), since removeReader resides in main. So, actually this lil' piece of the patch has no effect at all. BTW, what's a good way to close a server? That patch of code does it, but it is overridden elsewhere.
A quick glance over twisted/protocols/ftp.py indicates to me that nowhere is loseConnection actually called on a Port. Where is it supposed to be? (And what's up with storing it as DTPLoseConnection? I never see that being used...) On my machine, at least, calling loseConnection on a Port *would* indeed cause it to blow up :) -- ______ __ __ _____ _ _ | ____ | \_/ |_____] |_____| |_____| |_____ | | | | @ t w i s t e d m a t r i x . c o m http://twistedmatrix.com/users/glyph