Re: [Twisted-Python] Re: plus mode was Re: how winnt fileops workandwhat to do about it

----- Original Message ----- From: "Paul G" To: "Twisted general discussion" Sent: Saturday, December 31, 2005 4:57 PM Subject: Re: [Twisted-Python] Re: plus mode was Re: how winnt fileops workandwhat to do about it

----- Original Message ----- From: To: "Twisted general discussion" Sent: Saturday, December 31, 2005 4:33 PM Subject: Re: [Twisted-Python] Re: plus mode was Re: how winnt fileops workand what to do about it

...

On Sat, 31 Dec 2005 15:21:45 -0500, Paul G wrote:

...

2. say that across all platforms python supports given functionality on, said functionality needs to have functionally identical results given identical input. in this case, the flush+seek workaround needs to be utilized on all cpythons linked with msvscrt in a manner transparent to the user.

It seems like we can work around this more easily than that, considering that flush and seek are available from Twisted; the file object causing problems in the tests is being returned from the open() method of a FilePath object, if I understand it correctly. FilePath could include the workaround far in advance of Python deciding to.

oh, it makes perfect sense to have a workaround in twisted, i'm not suggesting otherwise. however, it should be just that - a temporary workaround until cpython has a fix for the issue, because (outside of the offending libc implementation), that is the right place to fix it.

just to clarify: there was no question to the effect of 'should we fix this in twisted for now?' - i was presuming that this course of action would be obvious and, indeed, the one being taken. cory specifically asked where i thought the bug was, so i explained my take on that. more importantly, it just occurred to me that even if the next minor cpython release contains this fix, we (and all python users) would still be stuck with this issue in previous releases. twisted would have to contain the workaround until the last version of cpython without the fix became unsupported, which could be quite a while. in light of this, not only should python be fixed, but this behaviour needs to be explained in the respective python docs quite prominently as well. -p