On Sun, 6 Nov 2011 13:53:24 -0500, Tom Davis wrote:

On Nov 6, 2011, at 12:51 PM, Jonathan Jacobs wrote:

...

Hello,

I recently volunteered to make some visual improvements to the Twisted Trac website. I received a lot of good feedback and suggestions from the IRC channel, most of which I took to heart and fine-tuned the changes. I think everyone is generally happy with the changes, I'm happy with the changes and I'd like help with moving things forward to eventually deploy these changes.

The branch is currently up for review on Launchpad[1], the merge proposal contains links to some[2] static[3] pages demonstrating the style changes. (It is worth noting that there are some quirks that are as a result of "File -> Save As" in Firefox, I wouldn't worry about these.)

I am willing to help with the final deployment of the site changes as well as integrating the new styling with: * the Sphinx documentation and documentation tools; * the Lore documentation (which I see thijs recently did some work on) if that is necessary; * and the pydoctor API documentation.

Wow Jonathan, these changes look great!

Indeed, this looks great! On https://dl.dropbox.com/u/4030134/Twisted/5047.htm, the status "Enhancement", "Fixed", "Closed" are not really vertically centered in their boxes, is it one of the Firefox quirks you were speaking about? Great job! Jonathan

On Mon, Nov 7, 2011 at 9:13 AM, anatoly techtonik wrote:

On Sun, Nov 6, 2011 at 8:51 PM, Jonathan Jacobs wrote:

...

Hello, I recently volunteered to make some visual improvements to the Twisted Trac website. I received a lot of good feedback and suggestions from the IRC channel, most of which I took to heart and fine-tuned the changes. I think everyone is generally happy with the changes, I'm happy with the changes and I'd like help with moving things forward to eventually deploy these changes. The branch is currently up for review on Launchpad[1], the merge proposal contains links to some[2] static[3] pages demonstrating the style changes. (It is worth noting that there are some quirks that are as a result of "File -> Save As" in Firefox, I wouldn't worry about these.)

Cool. I've uploaded screenshots to see how it looks on my FF7 below. I like it. Well, with the exception of linefeeds in download links and some stuff that is strictly subjective. For example, blue cloud looks completely out of the way on the main page - I don't know if it is thanks to the dark background or to its form. I also prefer right-side panels over left-side. On issue page red and blue tones are also looking strange to me. What is awesome are comment numbers. A pity these are not clickable.

Anyway, good work! =)

old - http://i42.tinypic.com/29dify0.jpg new - http://i44.tinypic.com/xpv78k.png

Yes, the cloud's arrow looks a little too green. Making it more green-yellow like the original download arrow might be better. See "Chameleon" in the Tango pallete: http://webcvs.freedesktop.org/tango/tango-art-tools/palettes/Tango-Palette.p...

...

[1] https://code.launchpad.net/~jjacobs/twisted-website/visual-design-update/+me... [2] https://dl.dropbox.com/u/4030134/Twisted/Twisted.htm [3] https://dl.dropbox.com/u/4030134/Twisted/5047.htm -- anatoly t.

_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

--   Jasper

On Mon, Nov 7, 2011 at 9:53 AM, Jonathan Jacobs wrote:

On Mon, Nov 7, 2011 at 16:31, Jasper St. Pierre wrote:

...

Yes, the cloud's arrow looks a little too green. Making it more green-yellow like the original download arrow might be better.

For what it's worth the colour of the arrow in Anatoly's screenshot looks far greener than the way the image appears on my screen, it's probably not worth only trusting screenshots (with who knows what colour profile transformations applied) when making colour comparisons.

The actual colour is much closer to the "Chameleon" colour from the Tango palette than the colour from Anatoly's image.

It's that way on my FF7 as well. Welcome to color spaces.

_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

--   Jasper