[Twisted-Python] code contribution/participation policy
![](https://secure.gravatar.com/avatar/9f68f881fb50ddb58f4fe289ffefceb9.jpg?s=120&d=mm&r=g)
Hi all, I have started working with Twisted and found it to be a very powerful package. That said, some modules are not documented very thoroughly (big surprise in the world of software, right?) and I also found some questionable code, too. If I were to contribute fixes/improvements, what is the submission procedure? Thanks. Boris.
![](https://secure.gravatar.com/avatar/e589db6c27c54b03de756cae2843dba5.jpg?s=120&d=mm&r=g)
Hi Boris, Probably the best starting point is https://twistedmatrix.com/trac/wiki/FrequentlyAskedQuestions#RequestsandCont... and specifically https://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs and https://twistedmatrix.com/trac/wiki/TwistedDevelopment There are a lot of little details in those documents, please read them carefully... but overall, the process is (1) Find/make a ticket (on trac, not github), (2) Make a github pull request, and (3) set the trac ticket up to be reviewed. Happy hacking! Colin On Fri, Aug 21, 2020 at 7:36 PM Boris Epstein <borepstein@gmail.com> wrote:
![](https://secure.gravatar.com/avatar/9f68f881fb50ddb58f4fe289ffefceb9.jpg?s=120&d=mm&r=g)
Hello all, Thanks again for your help. OK, so I think I have taken the first step: https://twistedmatrix.com/trac/ticket/9951 Now how do I proceed? What is the convention for Git brach names, etc? Cheers, Boris. On Sat, Aug 29, 2020 at 9:39 AM Boris Epstein <borepstein@gmail.com> wrote:
![](https://secure.gravatar.com/avatar/469df05f5dfd5b75fb3cb3a0868d36bf.jpg?s=120&d=mm&r=g)
On Sat, Sep 5, 2020 at 10:25 AM Boris Epstein <borepstein@gmail.com> wrote:
Now how do I proceed? What is the convention for Git brach names, etc?
This document should give you the steps to create a Git branch and proceed with a PR: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch -- Craig
![](https://secure.gravatar.com/avatar/9f68f881fb50ddb58f4fe289ffefceb9.jpg?s=120&d=mm&r=g)
Hello all, Thank you. Just submitted my first PR into the Twisted repo. Hopefully it is all good. Here's the relevant ticket: https://twistedmatrix.com/trac/ticket/9951 Cheers, Boris. On Mon, Sep 14, 2020 at 1:49 PM Glyph <glyph@twistedmatrix.com> wrote:
![](https://secure.gravatar.com/avatar/e589db6c27c54b03de756cae2843dba5.jpg?s=120&d=mm&r=g)
Hi Boris, Probably the best starting point is https://twistedmatrix.com/trac/wiki/FrequentlyAskedQuestions#RequestsandCont... and specifically https://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs and https://twistedmatrix.com/trac/wiki/TwistedDevelopment There are a lot of little details in those documents, please read them carefully... but overall, the process is (1) Find/make a ticket (on trac, not github), (2) Make a github pull request, and (3) set the trac ticket up to be reviewed. Happy hacking! Colin On Fri, Aug 21, 2020 at 7:36 PM Boris Epstein <borepstein@gmail.com> wrote:
![](https://secure.gravatar.com/avatar/9f68f881fb50ddb58f4fe289ffefceb9.jpg?s=120&d=mm&r=g)
Hello all, Thanks again for your help. OK, so I think I have taken the first step: https://twistedmatrix.com/trac/ticket/9951 Now how do I proceed? What is the convention for Git brach names, etc? Cheers, Boris. On Sat, Aug 29, 2020 at 9:39 AM Boris Epstein <borepstein@gmail.com> wrote:
![](https://secure.gravatar.com/avatar/469df05f5dfd5b75fb3cb3a0868d36bf.jpg?s=120&d=mm&r=g)
On Sat, Sep 5, 2020 at 10:25 AM Boris Epstein <borepstein@gmail.com> wrote:
Now how do I proceed? What is the convention for Git brach names, etc?
This document should give you the steps to create a Git branch and proceed with a PR: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch -- Craig
![](https://secure.gravatar.com/avatar/9f68f881fb50ddb58f4fe289ffefceb9.jpg?s=120&d=mm&r=g)
Hello all, Thank you. Just submitted my first PR into the Twisted repo. Hopefully it is all good. Here's the relevant ticket: https://twistedmatrix.com/trac/ticket/9951 Cheers, Boris. On Mon, Sep 14, 2020 at 1:49 PM Glyph <glyph@twistedmatrix.com> wrote:
participants (4)
-
Boris Epstein
-
Colin Dunklau
-
Craig Rodrigues
-
Glyph