[Twisted-Python] Twisted 17.5 vs txkube
![](https://secure.gravatar.com/avatar/607cfd4a5b41fe6c886c978128b9c03e.jpg?s=120&d=mm&r=g)
Hello, Sadly the txkube test suite is still pretty busted against Twisted 17.5. It was broken for a long time with Twisted 17.1 as well. I'm not sure if these are exactly the same problems or not but they look somewhat related. https://travis-ci.org/LeastAuthority/txkube/builds/269920984 If anyone feels like getting to the bottom of this, I'd appreciate it. Jean-Paul
![](https://secure.gravatar.com/avatar/3d37232726396a1d3c7412dd915095ea.jpg?s=120&d=mm&r=g)
I took a stab at some fixes a while ago in https://github.com/LeastAuthority/txkube/pull/135 <https://github.com/LeastAuthority/txkube/pull/135> -- some using private APIs, if I remember, sadly -- but I don't have the time at the moment to get it in a mergable state. But it might be a good start for others. - Amber
![](https://secure.gravatar.com/avatar/469df05f5dfd5b75fb3cb3a0868d36bf.jpg?s=120&d=mm&r=g)
I submitted one pull request, based on Amber's previous patch: https://github.com/LeastAuthority/txkube/pull/150 that brings the test failures down to only 1 failed test with Twisted 17.5.0 on Python 2.7. For the last failing test, it looks like It looks like changes which went into Twisted 17.1 for HostnameEndpoint and SSL here: https://github.com/twisted/twisted/pull/624 are causing that test to fail. I'm not so familiar with Endpoints and SSL, so that will take a while for me to figure out. -- Craig On Wed, Aug 30, 2017 at 5:05 AM, Jean-Paul Calderone < exarkun@twistedmatrix.com> wrote:
![](https://secure.gravatar.com/avatar/3d37232726396a1d3c7412dd915095ea.jpg?s=120&d=mm&r=g)
I took a stab at some fixes a while ago in https://github.com/LeastAuthority/txkube/pull/135 <https://github.com/LeastAuthority/txkube/pull/135> -- some using private APIs, if I remember, sadly -- but I don't have the time at the moment to get it in a mergable state. But it might be a good start for others. - Amber
![](https://secure.gravatar.com/avatar/469df05f5dfd5b75fb3cb3a0868d36bf.jpg?s=120&d=mm&r=g)
I submitted one pull request, based on Amber's previous patch: https://github.com/LeastAuthority/txkube/pull/150 that brings the test failures down to only 1 failed test with Twisted 17.5.0 on Python 2.7. For the last failing test, it looks like It looks like changes which went into Twisted 17.1 for HostnameEndpoint and SSL here: https://github.com/twisted/twisted/pull/624 are causing that test to fail. I'm not so familiar with Endpoints and SSL, so that will take a while for me to figure out. -- Craig On Wed, Aug 30, 2017 at 5:05 AM, Jean-Paul Calderone < exarkun@twistedmatrix.com> wrote:
participants (3)
-
Amber Hawkie Brown
-
Craig Rodrigues
-
Jean-Paul Calderone