[Twisted-Python] Prhaps 11.1rc2 should include #4669?
It seems like keeping IOCP from being broken on win64 is worth integrating.
On Nov 2, 2011, at 8:44 AM, Itamar Turner-Trauring wrote:
It seems like keeping IOCP from being broken on win64 is worth integrating.
Did it work on win64 in 11.0? If so, then this is a regression and needs to be fixed. If not, I'd say this is just a good motivation to get done with 11.1 and get the ball rolling on an 11.2 ASAP! :) -glyph
On Nov 2, 2011, at 9:35 PM, Itamar Turner-Trauring wrote:
Hrm. Looking at trunk, I guess we might be in a situation where we have to cherry-pick to get the regressions. Here's what's happened since 11.1rc1, if anyone wants to object on the basis of a risky change: <http://twistedmatrix.com/trac/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=33057&stop_rev=32950&limit=100> My impressions is that some of these are frighteningly subtle, but those are mostly bugfixes in equally highly subtle (but wrong) win32 code; given the relatively improved state of the buildbots I don't have any concerns. So I don't object, and anyway. Ultimately, Thomas gets to make the call as the release manager anyway, though :). -glyph
On Nov 2, 2011, at 8:44 AM, Itamar Turner-Trauring wrote:
It seems like keeping IOCP from being broken on win64 is worth integrating.
Did it work on win64 in 11.0? If so, then this is a regression and needs to be fixed. If not, I'd say this is just a good motivation to get done with 11.1 and get the ball rolling on an 11.2 ASAP! :) -glyph
On Nov 2, 2011, at 9:35 PM, Itamar Turner-Trauring wrote:
Hrm. Looking at trunk, I guess we might be in a situation where we have to cherry-pick to get the regressions. Here's what's happened since 11.1rc1, if anyone wants to object on the basis of a risky change: <http://twistedmatrix.com/trac/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=33057&stop_rev=32950&limit=100> My impressions is that some of these are frighteningly subtle, but those are mostly bugfixes in equally highly subtle (but wrong) win32 code; given the relatively improved state of the buildbots I don't have any concerns. So I don't object, and anyway. Ultimately, Thomas gets to make the call as the release manager anyway, though :). -glyph
participants (3)
-
Glyph -
Glyph Lefkowitz
-
Itamar Turner-Trauring