On Thu, 30 Sep 2004 10:12:18 +0200, Stefan Behnel wrote:

Hi!

I'm curious: how much work would it be to enable IPv6 support in twisted.internet?

I get a number of references to IPv4 that make me believe that t.i.* is not quite IPv6 clean by itself:

What would be needed? Would a new reactor be a good solution? "reactor6" ? Or rather extending the current one?

I'd say a reactor6 would be cleaner, but on the other hand, a simple flag could do the trick from the API perspective.

Any comments on this?

That a new reactor would solve nothing since the reactor is not the responsible for connections. Connection.py and tcp.py are the modules you are looking for (those that create the connection). Also there's a problem if you only write a new reactor, that IPv6 couldn't be used in other reactors, which is bad :). I'd rather hack on tcp.py and Connection.py and address.py (all in twisted.internet). Those sockets that you see in default.py are to wake up the main thread under windows IIRC. Since Twisted is very layered what happens at a lower level is actually unknown to the upper layers. So yes, twisted is not yet ready for IPv6, but implementing it won't brake anything (unless you use IPv6 by default). Maybe providing connectTCP6 could be a solution. -- Valentino Volonghi aka Dialtone Linux User #310274, Proud Gentoo User Blog: http://vvolonghi.blogspot.com Home Page: http://xoomer.virgilio.it/dialtone/

exarkun@divmod.com schrieb:

On Thu, 30 Sep 2004 10:12:18 +0200, Stefan Behnel wrote:

...

I'm curious: how much work would it be to enable IPv6 support in twisted.internet?

Not very much. About a year ago, I wrote this: http://cvs.twistedmatrix.com/cvs/trunk/sandbox/exarkun/ipv6.py?view=markup&rev=10540&root=Twisted This is no longer how I'd like to see IPv6 supported in Twisted, but it gives an idea of how few changes are required.

That really doesn't seem to be a big change in the current code base. It's not very object oriented, though, so as you said, it would have to be rewritten to integrate it with Twisted. However, I think the address handling would be a thing worth generalizing. I found this on the web: http://c0re.23.nu/c0de/IPy/ I already had to adapt it a bit as some code parts are somewhat clumsy, but I find it a nice abstraction for IP addresses. If such a thing was part of Twisted, the interfaces for handling IPv[46] could become completely transparent. You could even cut them into the existing interfaces: ----------------------------------------- from IPy import IP def connectTCP(host, port, ...) if isinstance(host, str): ... # use original IPv4 implementation - or convert host to IP(host) elif isinstance(host, IP): ... # connect either with IPv4 or IPv6, depending on host.version() ----------------------------------------- Stefan