[Twisted-Python] getting #2015 (Generic SASL library) moving again?
I'd like to see this ticket get moving again. I've gone over what's been done so far (and put my comments in the ticket), and it looks like everything is at least mostly ready to be merged into the Twisted trunk. So what else needs to be done to get this to happen? I'm happy to try and get it done, but a little direction would be really handy. ;) Kevin Horn
On Mon, Oct 5, 2009 at 12:34 PM, Kevin Horn <kevin.horn@gmail.com> wrote:
I'd like to see this ticket get moving again.
Excellent!
I've gone over what's been done so far (and put my comments in the ticket), and it looks like everything is at least mostly ready to be merged into the Twisted trunk.
Your analysis on the ticket looks fairly thorough.
So what else needs to be done to get this to happen? I'm happy to try and get it done, but a little direction would be really handy. ;)
The workflow is pretty simple. 1. author submits change 2. reviewer reviews change 3. someone responds to feedback 4. "someone" becomes "author", repeat Right now we're stuck in the middle of step 3, but given that therve does not appear to be actively working on this branch, the path forward is clear. *You* become "someone", and submit a patch that finishes dealing with the issues that you have mentioned as not already taken care of by therve's subsequent changesets. The best way to do this is to submit a patch against the branch, rather than against trunk. Given such a patch, a twisted committer can then apply the patch to the branch and submit to buildbots (etc) as appropriate. By submitting it against the branch, you make it easy for the reviewer to examine the changes you're submitting in isolation from the rest of the larger change, to see if they address the points that you've brought up. If the reviewer is happy with your changes, then the patch + branch will be immediately merged to trunk; of course, the next review might have a little more feedback for you to deal with ;). Thanks for your interest!
On Mon, Oct 5, 2009 at 1:32 PM, Glyph Lefkowitz <glyph@twistedmatrix.com>wrote:
On Mon, Oct 5, 2009 at 12:34 PM, Kevin Horn <kevin.horn@gmail.com> wrote:
I'd like to see this ticket get moving again.
Excellent!
I've gone over what's been done so far (and put my comments in the ticket), and it looks like everything is at least mostly ready to be merged into the Twisted trunk.
Your analysis on the ticket looks fairly thorough.
Thanks! Though, really I just went over the changesets that therve submitted, and checked them against exarkun's suggestions.
So what else needs to be done to get this to happen? I'm happy to try and get it done, but a little direction would be really handy. ;)
The workflow is pretty simple.
1. author submits change 2. reviewer reviews change 3. someone responds to feedback 4. "someone" becomes "author", repeat
Right now we're stuck in the middle of step 3, but given that therve does not appear to be actively working on this branch, the path forward is clear. *You* become "someone", and submit a patch that finishes dealing with the issues that you have mentioned as not already taken care of by therve's subsequent changesets. The best way to do this is to submit a patch against the branch, rather than against trunk. Given such a patch, a twisted committer can then apply the patch to the branch and submit to buildbots (etc) as appropriate. By submitting it against the branch, you make it easy for the reviewer to examine the changes you're submitting in isolation from the rest of the larger change, to see if they address the points that you've brought up.
If the reviewer is happy with your changes, then the patch + branch will be immediately merged to trunk; of course, the next review might have a little more feedback for you to deal with ;).
Thanks for your interest!
That's kind of what I figured.
From my previous review of the current status, it looks pretty well done to me, but I'll start taking a look at it in more detail, and see what I can come up with. Might need some more tests, etc.
Kevin "Someone" Horn
On Mon, Oct 5, 2009 at 1:49 PM, Kevin Horn <kevin.horn@gmail.com> wrote:
On Mon, Oct 5, 2009 at 1:32 PM, Glyph Lefkowitz <glyph@twistedmatrix.com>wrote:
On Mon, Oct 5, 2009 at 12:34 PM, Kevin Horn <kevin.horn@gmail.com> wrote:
I'd like to see this ticket get moving again.
Excellent!
I've gone over what's been done so far (and put my comments in the ticket), and it looks like everything is at least mostly ready to be merged into the Twisted trunk.
Your analysis on the ticket looks fairly thorough.
Thanks! Though, really I just went over the changesets that therve submitted, and checked them against exarkun's suggestions.
So what else needs to be done to get this to happen? I'm happy to try and get it done, but a little direction would be really handy. ;)
The workflow is pretty simple.
1. author submits change 2. reviewer reviews change 3. someone responds to feedback 4. "someone" becomes "author", repeat
Right now we're stuck in the middle of step 3, but given that therve does not appear to be actively working on this branch, the path forward is clear. *You* become "someone", and submit a patch that finishes dealing with the issues that you have mentioned as not already taken care of by therve's subsequent changesets. The best way to do this is to submit a patch against the branch, rather than against trunk. Given such a patch, a twisted committer can then apply the patch to the branch and submit to buildbots (etc) as appropriate. By submitting it against the branch, you make it easy for the reviewer to examine the changes you're submitting in isolation from the rest of the larger change, to see if they address the points that you've brought up.
If the reviewer is happy with your changes, then the patch + branch will be immediately merged to trunk; of course, the next review might have a little more feedback for you to deal with ;).
Thanks for your interest!
That's kind of what I figured.
From my previous review of the current status, it looks pretty well done to me, but I'll start taking a look at it in more detail, and see what I can come up with. Might need some more tests, etc.
Kevin "Someone" Horn
FYI, this ticket back up for review... Kevin Horn
On Oct 26, 2009, at 5:11 PM, Kevin Horn wrote:
FYI, this ticket back up for review...
Thanks! Sorry about the review backlog; the core committers have all been pretty busy lately. I'll try to get to this soon.
participants (2)
-
Glyph Lefkowitz -
Kevin Horn