[Twisted-Python] Twisted 18.7.0rc1 Release Candidate Announcement
Hello everyone, from scenic Heathrow airport. It's time for another Twisted release, and this one has got some goodies. Included in this release are: - better support for async/await coroutines in regards to exception and traceback handling; - better support for reporting tracebacks in inlineCallbacks, now showing what you would expect in synchronous-like code - the epoll reactor now no longer hard-locks when running out of file descriptors - directory rendering in t.web works on Python 2 again - manhole's colouriser is better at handling Unicode - setting the groundwork for Python 3.7 support. Note that Python 3.7 is currently not a supported platform on any operating system, and may completely fail to install, especially on Windows. You can get this hot, fresh Twisted for testing through PyPI: pip install Twisted==18.7.0rc1 You can read the full changelog here: https://github.com/twisted/twisted/blob/release-18.7.0-9475/NEWS.rst Please do some testing, and if all goes well, 18.7 will release proper in a week. - Amber
Am 04.07.2018 um 12:44 schrieb Amber Brown:
You can read the full changelog here:
https://github.com/twisted/twisted/blob/release-18.7.0-9475/NEWS.rst
Please do some testing, and if all goes well, 18.7 will release proper in a week.
Noticed a documentation issue with #9387 (see #9479) and as I was preparing a patch for it, I noticed that it implemented `samesite` as an argument which AFAIU is in violation of Twisted coding style. Just to illustrate: the same method has another parameter called `httpOnly` and one called `max_age`. Having `samesite` adds yet a third style to the same method. AFAIU, the Naming Convention suggests it should be `sameSite` instead. Opened another ticket for that (#9480). Since once this is released, it's pretty much un-changable, I would think it's release critical; "Release blocker: Regression" sounded like the most suitable tag. See Pull Request: https://github.com/twisted/twisted/pull/1036 #9479: https://twistedmatrix.com/trac/ticket/9387 https://github.com/twisted/twisted/commit/1504c345c2b3ce73b63cf8d27f353c5e9b... #9479: https://twistedmatrix.com/trac/ticket/9479 #9480: https://twistedmatrix.com/trac/ticket/9480 -- Evilham
On Jul 4, 2018, at 7:38 AM, Evilham <contact@evilham.com> wrote:
Am 04.07.2018 um 12:44 schrieb Amber Brown:
You can read the full changelog here:
https://github.com/twisted/twisted/blob/release-18.7.0-9475/NEWS.rst
Please do some testing, and if all goes well, 18.7 will release proper in a week.
Noticed a documentation issue with #9387 (see #9479) and as I was preparing a patch for it, I noticed that it implemented `samesite` as an argument which AFAIU is in violation of Twisted coding style.
Just to illustrate: the same method has another parameter called `httpOnly` and one called `max_age`. Having `samesite` adds yet a third style to the same method. AFAIU, the Naming Convention suggests it should be `sameSite` instead.
Opened another ticket for that (#9480). Since once this is released, it's pretty much un-changable, I would think it's release critical; "Release blocker: Regression" sounded like the most suitable tag.
See Pull Request: https://github.com/twisted/twisted/pull/1036 <https://github.com/twisted/twisted/pull/1036>
Hmm. It does look like in most other contexts this is presented as two words: https://caniuse.com/#search=samesite <https://caniuse.com/#search=samesite> so I think I agree with Evilham; let's fix it now. Thanks for paying such close attention to detail! -g
On Jul 4, 2018, at 10:52 AM, Glyph <glyph@twistedmatrix.com> wrote:
On Jul 4, 2018, at 7:38 AM, Evilham <contact@evilham.com <mailto:contact@evilham.com>> wrote:
Am 04.07.2018 um 12:44 schrieb Amber Brown:
You can read the full changelog here:
https://github.com/twisted/twisted/blob/release-18.7.0-9475/NEWS.rst <https://github.com/twisted/twisted/blob/release-18.7.0-9475/NEWS.rst>
Please do some testing, and if all goes well, 18.7 will release proper in a week.
Noticed a documentation issue with #9387 (see #9479) and as I was preparing a patch for it, I noticed that it implemented `samesite` as an argument which AFAIU is in violation of Twisted coding style.
Just to illustrate: the same method has another parameter called `httpOnly` and one called `max_age`. Having `samesite` adds yet a third style to the same method. AFAIU, the Naming Convention suggests it should be `sameSite` instead.
Opened another ticket for that (#9480). Since once this is released, it's pretty much un-changable, I would think it's release critical; "Release blocker: Regression" sounded like the most suitable tag.
See Pull Request: https://github.com/twisted/twisted/pull/1036 <https://github.com/twisted/twisted/pull/1036>
Hmm. It does look like in most other contexts this is presented as two words: https://caniuse.com/#search=samesite <https://caniuse.com/#search=samesite> so I think I agree with Evilham; let's fix it now.
Thanks for paying such close attention to detail!
Appveyor is very slow, so I don't have time to sit around and wait, but this is provisionally approved to land whenever someone comes along to see that CI is actually passing. -g
participants (3)
-
Amber Brown -
Evilham -
Glyph