[Twisted-Python] Re: [Twisted-commits] Add callMultipleInThread and deferToThread to the reactor interface.
bruce CVS wrote:
Modified files: Twisted/twisted/internet/base.py 1.9 1.10 Twisted/twisted/internet/interfaces.py 1.17 1.18
Log message: Add callMultipleInThread and deferToThread to the reactor interface.
We originally did *not* add this since they are utility methods and the reactor interface should be minimal. This should be removed and reverted to the way it was before (unless glyph disagrees?).
Itamar Shtull-Trauring wrote:
bruce CVS wrote:
Modified files: Twisted/twisted/internet/base.py 1.9 1.10 Twisted/twisted/internet/interfaces.py 1.17 1.18
Log message: Add callMultipleInThread and deferToThread to the reactor interface.
We originally did *not* add this since they are utility methods and the reactor interface should be minimal. This should be removed and reverted to the way it was before (unless glyph disagrees?).
Glyph had agreed with the changes prior to my committing them (on IRC), but if he disagrees, I'm happy to revert them, although I do think they should be exposed in this way. - Bruce
From: Itamar Shtull-Trauring
bruce CVS wrote:
Modified files: Twisted/twisted/internet/base.py 1.9 1.10 Twisted/twisted/internet/interfaces.py 1.17 1.18
Log message: Add callMultipleInThread and deferToThread to the reactor interface.
We originally did *not* add this since they are utility methods and the reactor interface should be minimal. This should be removed and reverted to the way it was before (unless glyph disagrees?).
Argh! I was distracted and did not listen to Bruce's question properly. Yes. This should be reverted. -- | <`'> | Glyph Lefkowitz: Traveling Sorcerer | | < _/ > | Lead Developer, the Twisted project | | < ___/ > | http://www.twistedmatrix.com |
Glyph Lefkowitz wrote:
From: Itamar Shtull-Trauring
We originally did *not* add this since they are utility methods and the reactor interface should be minimal. This should be removed and reverted to the way it was before (unless glyph disagrees?).
Argh! I was distracted and did not listen to Bruce's question properly. Yes. This should be reverted.
And done. But I did leave in the docs for the stuff that wasn't previously directly mentioned in doc/howto/threading.html. - Bruce
participants (3)
-
Bruce Mitchener -
Glyph Lefkowitz -
Itamar Shtull-Trauring