[Twisted-Python] Re: [Twisted-commits] r12768 - Make SVN ignore files generated by unit tests.
On Thu, 2004-12-23 at 03:07 -0700, Tommi Virtanen wrote:
Modified: trunk/twisted/lore/test/ (props changed) trunk/twisted/test/ (props changed) Log: Make SVN ignore files generated by unit tests.
Really we should fix the tests so that the files are not created under the twisted/ tree.
Some Twisted mailing list messages are getting dropped in my spam bucket in the same way this one was. It might make sense to contact the SURBL groups and get twistedmatrix.com off their lists. Bill Gribble
Content analysis details: (6.0 points, 5.0 required)
pts rule name description ---- ---------------------- -------------------------------------------------- -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 1.0 URIBL_PH_SURBL Contains a URL listed in the PH SURBL blocklist [URIs: twistedmatrix.com] 1.0 URIBL_AB_SURBL Contains a URL listed in the AB SURBL blocklist [URIs: twistedmatrix.com] 1.8 URIBL_WS_SURBL Contains a URL listed in the WS SURBL blocklist [URIs: twistedmatrix.com] 1.0 URIBL_OB_SURBL Contains a URL listed in the OB SURBL blocklist [URIs: twistedmatrix.com] 3.8 URIBL_SC_SURBL Contains a URL listed in the SC SURBL blocklist
Wow, I really wouldn't recommend scoring a single external source so high that it, all by itself, can mark your emails as spam. Also, http://www.rulesemporium.com/cgi-bin/uribl.cgi doesn't say anything about twistedmatrix.com being on their list. Maybe they just removed it, or maybe your configuration is broken somehow. James On Dec 23, 2004, at 10:32 AM, Bill Gribble wrote:
Some Twisted mailing list messages are getting dropped in my spam bucket in the same way this one was. It might make sense to contact the SURBL groups and get twistedmatrix.com off their lists.
Bill Gribble
Content analysis details: (6.0 points, 5.0 required)
pts rule name description ---- ---------------------- -------------------------------------------------- -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 1.0 URIBL_PH_SURBL Contains a URL listed in the PH SURBL blocklist [URIs: twistedmatrix.com] 1.0 URIBL_AB_SURBL Contains a URL listed in the AB SURBL blocklist [URIs: twistedmatrix.com] 1.8 URIBL_WS_SURBL Contains a URL listed in the WS SURBL blocklist [URIs: twistedmatrix.com] 1.0 URIBL_OB_SURBL Contains a URL listed in the OB SURBL blocklist [URIs: twistedmatrix.com] 3.8 URIBL_SC_SURBL Contains a URL listed in the SC SURBL blocklist
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Itamar Shtull-Trauring wrote:
Modified: trunk/twisted/lore/test/ (props changed) trunk/twisted/test/ (props changed) Log: Make SVN ignore files generated by unit tests.
Really we should fix the tests so that the files are not created under the twisted/ tree.
I agree. However, that was not a <5 minute task for me. twisted/test/myrebuilder.py is imported; if you put it somewhere else, you need to do sys.path hacking or such. twisted/lore/test/ ignored files are created by things where I see no simple option for setting the destination directory. Someone who knows lore better may want to pick that up.
On Sat, 2004-12-25 at 12:59 +0200, Tommi Virtanen wrote:
twisted/lore/test/ ignored files are created by things where I see no simple option for setting the destination directory. Someone who knows lore better may want to pick that up.
One would copy the files to mkdir(TestCase/mktemp(self)) and then run the tests on the copies.
Itamar Shtull-Trauring wrote:
twisted/lore/test/ ignored files are created by things where I see no simple option for setting the destination directory. Someone who knows lore better may want to pick that up.
One would copy the files to mkdir(TestCase/mktemp(self)) and then run the tests on the copies.
I though of that, too, but considered it too messy at the time (basically because I was too tired to actually read the code). I just committed r12789:12791 which do exactly that. That still leaves this: twisted/test/myrebuilder.py is imported; if you put it somewhere else, you need to do sys.path hacking or such.
participants (4)
-
Bill Gribble -
Itamar Shtull-Trauring -
James Y Knight -
Tommi Virtanen