[Twisted-Python] Need help reviewing improvement to inlineCallbacks

Sept. 20, 2017
4:42 p.m.
Pierre Tardy, the main developer of Buildbot, submitted this patch to add full stack traces to inlineCallbacks: https://github.com/twisted/twisted/pull/814 I think the patch looks good, but can someone with more knowledge of inlineCallbacks review it? Right now, if you have a stack of inlineCallbacks, andan exception is thrown, some of the stacktrace is lost. By adding full stack traces to inlineCallbacks, this greatly improves the debuggability of software like Buildbot, which makes heavy use of inlineCallbacks. -- Craig
2732
Age (days ago)
2732
Last active (days ago)
0 comments
1 participants
participants (1)
-
Craig Rodrigues