[Twisted-Python] Re: [Twisted-commits] r14952 - Impelement spawnProcess for IOCP reactor. Resolves issue1008.
On Fri, 28 Oct 2005 10:38:02 -0600, Justin Johnson
Author: justinj Date: Fri Oct 28 10:38:01 2005 New Revision: 14952
Added: trunk/twisted/internet/iocpreactor/process.py - copied unchanged from r14928, branches/win32-process/twisted/internet/iocpreactor/process.py trunk/twisted/internet/iocpreactor/process_waiter.py - copied unchanged from r14928, branches/win32-process/twisted/internet/iocpreactor/process_waiter.py Modified: trunk/twisted/internet/iocpreactor/ops.py trunk/twisted/internet/iocpreactor/proactor.py trunk/twisted/test/process_tester.py trunk/twisted/test/test_process.py trunk/twisted/topfiles/INSTALL Log: Impelement spawnProcess for IOCP reactor. Resolves issue1008.
While I am excited this feature is so close, it seems like it isn't quite there yet. Buildbot is now reporting only 442 tests run by the IOCP builder on Win32, and a really nasty looking traceback afterwards. Could we revert this merge? Jean-Paul
On Fri, Oct 28, 2005 at 11:26:22PM -0400, Jean-Paul Calderone wrote:
On Fri, 28 Oct 2005 10:38:02 -0600, Justin Johnson
wrote: [...] Log: Impelement spawnProcess for IOCP reactor. Resolves issue1008.
While I am excited this feature is so close, it seems like it isn't quite there yet. Buildbot is now reporting only 442 tests run by the IOCP builder on Win32, and a really nasty looking traceback afterwards.
Could we revert this merge?
The bug you notice existed before that merge too. Jonathan helped me diagnose it: see http://twistedmatrix.com/bugs/issue1294. It appears trial is calling reactor.iterate(0) during cleanup, and not expecting that it could raise an exception. Making iocp's doIteration swallow and log that error, like the other reactors do, will probably fix this. Making trial deal with that error better (as apparently is not too hard to do with one of the trial branches) would also fix it. -Andrew.
This problem is resolved with r14989.
On 10/29/05, Andrew Bennetts
On Fri, Oct 28, 2005 at 11:26:22PM -0400, Jean-Paul Calderone wrote:
On Fri, 28 Oct 2005 10:38:02 -0600, Justin Johnson
wrote: [...] Log: Impelement spawnProcess for IOCP reactor. Resolves issue1008.
While I am excited this feature is so close, it seems like it isn't quite there yet. Buildbot is now reporting only 442 tests run by the IOCP builder on Win32, and a really nasty looking traceback afterwards.
Could we revert this merge?
The bug you notice existed before that merge too. Jonathan helped me diagnose it: see http://twistedmatrix.com/bugs/issue1294. It appears trial is calling reactor.iterate(0) during cleanup, and not expecting that it could raise an exception. Making iocp's doIteration swallow and log that error, like the other reactors do, will probably fix this. Making trial deal with that error better (as apparently is not too hard to do with one of the trial branches) would also fix it.
-Andrew.
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
participants (3)
-
Andrew Bennetts
-
Jean-Paul Calderone
-
Justin Johnson