[Twisted-Python] twisted.positioning preliminary review
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey :-) I've been told that I need to produce a patch faster, and most of the eyesores that I was really unhappy with have been removed (no more mutable sentenceData dict \o/). As usual, comments welcome. I could produce an actual patch, but perhaps it would be more useful to do this with the Launchpad-published bzr branch? Obviously that means I can't attach a real patch to a trac ticket. If people want me to, I will. Some of the obvious problems that I've seen myself or that come up on the mailing list are tagged with "REVIEW", so if you only have 10 minutes to look at it, grep nmea.py for it :-) Obvious TODO is howto documentation, but I'm not starting on that until the API has been reviewed thoroughly for obvious reasons. Here it is: http://bit.ly/3wWL2c Or you could just: bzr branch lp:~lvh/twisted/positioning Thanks for your time Laurens -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Use GnuPG with Firefox : http://getfiregpg.org (Version: 0.7.8) iEYEARECAAYFAkp3hvsACgkQT5v5zGkvKT4vTwCdG41LE0snM8vdK1L9ohF8wZRo +T4An2RQz22QmjT1YFEAmOT8IHJyoT8C =WbHv -----END PGP SIGNATURE-----
On Mon, Aug 3, 2009 at 8:56 PM, Laurens Van Houtven
I could produce an actual patch, but perhaps it would be more useful to do this with the Launchpad-published bzr branch? Obviously that means I can't attach a real patch to a trac ticket. If people want me to, I will.
The ticket is currently pending review, so when someone has some time for Twisted reviews, you should get some feedback on it. You might want to attach a comment that makes it very clear for a reviewer where the code actually is, since the ticket seems to have begun its life in the 'review' state; it's a bit unorthodox for someone to keep working on a ticket once it's been submitted for review. The normal workflow is to have the comment that attaches the 'review' keyword be the submission for review, and the comment that removes it be the review commentary. (Or something close to that, trac's UI is so hard to drive.) We've got a bit of a review backlog right now so there may be some latency :-\. Perhaps you should volunteer to review some tickets yourself? :) The way to get from your launchpad branch to the relevant SVN-like diff is this: bzr get lp:~lvh/twisted/positioning positioning-3926 cd positioning-3926 bzr diff -r ancestor:lp:twisted Attaching this patch to the ticket may make a reviewer's life easier; not everyone is equally facile with bzr.
Some of the obvious problems that I've seen myself or that come up on the mailing list are tagged with "REVIEW", so if you only have 10 minutes to look at it, grep nmea.py for it :-)
Obvious TODO is howto documentation, but I'm not starting on that until the API has been reviewed thoroughly for obvious reasons.
This can be a separate ticket. Here it is: http://bit.ly/3wWL2c
Or you could just: bzr branch lp:~lvh/twisted/positioning http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Patch added! Reviewers rejoice. http://twistedmatrix.com/trac/ticket/3926 As usual, available on bzr: bzr branch lp:~lvh/twisted/positioning -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Use GnuPG with Firefox : http://getfiregpg.org (Version: 0.7.8) iEYEARECAAYFAkp7CG4ACgkQT5v5zGkvKT7MywCfYL69jpqVupaYZ0nKC2A+JrmD 4skAmwXa5ua+iQWdZRdOeXuwhSipdnSF =MXVb -----END PGP SIGNATURE-----
We've got a bit of a review backlog right now so there may be some latency :-\. Perhaps you should volunteer to review some tickets yourself? :)
I've reviewed a few now, only the ones that I understand though, which aren't that many :-D
Obvious TODO is howto documentation, but I'm not starting on that until the API has been reviewed thoroughly for obvious reasons.
This can be a separate ticket.
http://twistedmatrix.com/trac/ticket/3953 Enjoy Laurens
participants (2)
-
Glyph Lefkowitz
-
Laurens Van Houtven