On Sep 9, 2015, at 1:31 PM, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:

...

On Sep 9, 2015, at 7:51 AM, Adi Roiban <adi@roiban.ro <mailto:adi@roiban.ro>> wrote:

Is there anybody still using the diffresource links in Trac tickets?

If you are still using it, do you think you can use the GitHub diff instead?

Can we remove it from Trac?

I prefer the GitHub diff as I can use side-by-side view and expand the diff or go to full file.

Here is the associated ticket https://github.com/twisted-infra/braid/issues/102 <https://github.com/twisted-infra/braid/issues/102>

I still use it sometimes to apply the current patch to a working copy: quicker to type the URL.

Not sure if you know this, but if you click the “github” link under the branch name, and then add “.patch” to the end of a URL, you get a patch file that you can apply to a working copy.

That said I think that removing it is an acceptable regression for the git migration; it should be trivial to re-implement using git if anyone (including me) cares enough, and it should be substantially faster.

-radix