[Twisted-Python] Script which uploads coverage results to codecov failed, but reported success?
Hi, For this pull request: https://github.com/twisted/twisted/pull/284 This Windows build ran and tried to upload coverage results to codecov: https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7-coverage/build... but failed with this: Error: 403 Client Error: Forbidden for url: https://codecov.s3.amazonaws.com/v4/raw/2016-07-01/BB05435E28F8047E9B3D49B4B7BFA4B3/4a5903d2f0fcab3db7c6ca68ff563e2c859dd5c2/031e0d8f-aadc-47ae-9b69-29ca9d962287.txt?AWSAccessKeyId=AKIAIHLZSCQCS4WIHD4A&Expires=1467374016&Signature=i1IQndDSPC0vtJysR8vnPxDpPw0%3D The upload failed, but the buildbot job reported success. The result was that patch shows 57% coverage, when it should be 100%. Is there a way to make that buildbot step fail if the upload to codecov fails? I don't know where the script for that is. -- Craig
On Fri, Jul 1, 2016 at 11:34 AM, Craig Rodrigues <rodrigc@crodrigues.org> wrote:
Error: 403 Client Error: Forbidden for url: https://codecov.s3.amazonaws.com/v4/raw/2016-07-01/BB05435E28F8047E9B3D49B4B7BFA4B3/4a5903d2f0fcab3db7c6ca68ff563e2c859dd5c2/031e0d8f-aadc-47ae-9b69-29ca9d962287.txt?AWSAccessKeyId=AKIAIHLZSCQCS4WIHD4A&Expires=1467374016&Signature=i1IQndDSPC0vtJysR8vnPxDpPw0%3D
The upload failed, but the buildbot job reported success.
It looks like every build from the windows7-64-py2.6-coverage buildbot is failing to upload to codecov. I have filed a ticket: https://twistedmatrix.com/trac/ticket/8549#ticket -- Craig
On 1 July 2016 at 19:34, Craig Rodrigues <rodrigc@crodrigues.org> wrote:
Hi,
For this pull request:
https://github.com/twisted/twisted/pull/284
This Windows build ran and tried to upload coverage results to codecov:
https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7-coverage/build...
but failed with this:
I can see that the Windows coverage builder is not using virtualenv + tox to run the coverage report. I suggest that we should first convert all builders to virtualenv + tox. There is a ticket pending review for that https://twistedmatrix.com/trac/ticket/8544 Then I suggest to push the coverage from tox. There is a ticket pending review for that https://twistedmatrix.com/trac/ticket/8532 -------- With builders using virtual env + tox it should be much easier to work and debug issues as the exact commands executed by buildbot are no longer hardcoded in the buildbot configuration. -------- I have setup a buildslave for Windows 2012R2 on Rackspace and I can see that the coverage was uploaded ...at least for trunk https://buildbot.twistedmatrix.com/builders/win-64-py2.7-coverage/builds/1/s... The PR for adding the Windows 2012 slave is waiting a review here https://github.com/twisted-infra/braid/pull/215 --------- Craig, if you have access to the Windows 7 slave check the system clock. I no longer have access to the Win7 VNC as it looks like the password was changed. -- Adi Roiban
A bit of an aside... but both personally and in several businesses I work with, I've use Lastpass to manage passwords. Because the passwords are shared at the server, updated passwords are propagated to all users. It also has a really nice 2-factor option where your phone just offers you an "approve" button (no 6-digit codes to transcribe). Clayton Daley On Sun, Jul 3, 2016 at 2:27 AM, Adi Roiban <adi@roiban.ro> wrote:
On 1 July 2016 at 19:34, Craig Rodrigues <rodrigc@crodrigues.org> wrote:
Hi,
For this pull request:
https://github.com/twisted/twisted/pull/284
This Windows build ran and tried to upload coverage results to codecov:
https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7-coverage/build...
but failed with this:
I can see that the Windows coverage builder is not using virtualenv + tox to run the coverage report.
I suggest that we should first convert all builders to virtualenv + tox. There is a ticket pending review for that https://twistedmatrix.com/trac/ticket/8544
Then I suggest to push the coverage from tox. There is a ticket pending review for that https://twistedmatrix.com/trac/ticket/8532
--------
With builders using virtual env + tox it should be much easier to work and debug issues as the exact commands executed by buildbot are no longer hardcoded in the buildbot configuration.
--------
I have setup a buildslave for Windows 2012R2 on Rackspace and I can see that the coverage was uploaded ...at least for trunk
https://buildbot.twistedmatrix.com/builders/win-64-py2.7-coverage/builds/1/s...
The PR for adding the Windows 2012 slave is waiting a review here https://github.com/twisted-infra/braid/pull/215
---------
Craig, if you have access to the Windows 7 slave check the system clock. I no longer have access to the Win7 VNC as it looks like the password was changed.
-- Adi Roiban
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On Jul 3, 2016, at 00:27, Adi Roiban <adi@roiban.ro> wrote:
I no longer have access to the Win7 VNC as it looks like the password was changed.
The password hasn't been changed, so I'm not sure why you're having trouble accessing it. -glyph
participants (4)
-
Adi Roiban
-
Clayton Daley
-
Craig Rodrigues
-
Glyph Lefkowitz