type annotations code review trade?
I'd really like to land https://github.com/twisted/twisted/pull/11770 soon and it's been stuck in the queue for a while. Does anyone else have a PR they'd like to trade a review for? -g
https://github.com/twisted/twisted/pull/1274 On 26/06/2023 4:41 pm, Glyph wrote:
I'd really like to land https://github.com/twisted/twisted/pull/11770 soon and it's been stuck in the queue for a while. Does anyone else have a PR they'd like to trade a review for?
-g
_______________________________________________ Twisted mailing list -- twisted@python.org To unsubscribe send an email to twisted-leave@python.org https://mail.python.org/mailman3/lists/twisted.python.org/ Message archived at https://mail.python.org/archives/list/twisted@python.org/message/IB2ZPAUADJI... Code of Conduct: https://twisted.org/conduct
Done: https://github.com/twisted/twisted/pull/1274#pullrequestreview-1498955849 This is in a bit of a rough state and will probably take a few round trips, but if you want to keep trading back and forth, I have no shortage of other PRs that I'd like to land, and I'd love to help you get this over the line. -g
On Jun 26, 2023, at 1:56 AM, Ian Haywood <ian@haywood.id.au> wrote:
https://github.com/twisted/twisted/pull/1274
On 26/06/2023 4:41 pm, Glyph wrote:
I'd really like to land https://github.com/twisted/twisted/pull/11770 soon and it's been stuck in the queue for a while. Does anyone else have a PR they'd like to trade a review for?
-g
_______________________________________________ Twisted mailing list -- twisted@python.org To unsubscribe send an email to twisted-leave@python.org https://mail.python.org/mailman3/lists/twisted.python.org/ Message archived at https://mail.python.org/archives/list/twisted@python.org/message/IB2ZPAUADJI... Code of Conduct: https://twisted.org/conduct
Twisted mailing list -- twisted@python.org To unsubscribe send an email to twisted-leave@python.org https://mail.python.org/mailman3/lists/twisted.python.org/ Message archived at https://mail.python.org/archives/list/twisted@python.org/message/44R2W245LI3... Code of Conduct: https://twisted.org/conduct
participants (2)
-
Glyph
-
Ian Haywood