[Twisted-Python] making Screwtape (Tim Allen) a committer

I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews. Thoughts? (Feel free to voice any comments off-list, too.)

+1 On Wed, Jun 9, 2010 at 5:25 PM, Glyph Lefkowitz <glyph@twistedmatrix.com>wrote:
I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews.
Thoughts? (Feel free to voice any comments off-list, too.) _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

+2 On 10 Jun 2010, at 00:49, Kevin Horn wrote:
+1
On Wed, Jun 9, 2010 at 5:25 PM, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote: I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews.
Thoughts? (Feel free to voice any comments off-list, too.) _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

On Wed, Jun 09, 2010 at 06:25:05PM -0400, Glyph Lefkowitz wrote:
I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews.
Well, this is a bit of a boost to the ol' ego. :D The reason I've resisted asking for commit access before this is that most of my efforts for Twisted have been either (a) things directly useful for $EMPLOYER's Twisted deployments (such as the distutils changes you mention), or (b) things indirectly useful for the purposes of (a), such as cutting down the review queue to make it more likely that my patches will be reviewed. While my non-work-related contributions are non-zero, they're a lot less than my work-related contributions. That said, I've been following the Twisted project since (checks mailing-list archive) October 2002, and I fully intend to keep contributing reviews at the very least no matter who my employer is at the time. If you still think I'm a good candidate for committership, I'll happily accept. Tim "Screwtape" Allen

Glyph Lefkowitz wrote:
I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews.
+1 I've been thinking (and occasionally saying) this for months! -Andrew.

Unless there's stuff most of us don't see, I don't see how anyone could object :-) +1 lvh

On 9 June 2010 23:25, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:
I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews.
Thoughts? (Feel free to voice any comments off-list, too.)
OK, so this is extreme pedantry but I didn't think Twisted had the concept of official reviewer :-) Cheers, mwh

On Thu, Jun 24, 2010 at 1:14 PM, Michael Hudson-Doyle <micahel@gmail.com> wrote:
On 9 June 2010 23:25, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:
I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews.
Thoughts? (Feel free to voice any comments off-list, too.)
OK, so this is extreme pedantry but I didn't think Twisted had the concept of official reviewer :-)
There seems to be a policy, although I'm not sure if this is actually written down anywhere, that for a branch/patch to be merged to trunk, either the author should be a committer, or (one of) the reviewer(s) should be a committer. So, I guess an "official" reviewer would just be someone with commit access? -- mithrandi, i Ainil en-Balandor, a faer Ambar

+1! On Wed, Jun 9, 2010 at 6:25 PM, Glyph Lefkowitz <glyph@twistedmatrix.com>wrote:
I think we should give screwtape an SVN account and make him an official reviewer. He's been doing a lot of work on the distutils code which would be made easier by that, and he's been doing pretty decent reviews.
Thoughts? (Feel free to voice any comments off-list, too.) _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
participants (9)
-
Andrew Bennetts
-
Glyph Lefkowitz
-
Jessica McKellar
-
Kevin Horn
-
Laurens Van Houtven
-
Michael Hudson-Doyle
-
Thijs Triemstra | Collab
-
Tim Allen
-
Tristan Seligmann