[Twisted-Python] Trial and ImportErrors
Hello, For a while I've been thinking of changing Trial so that import errors flag the test suite as failed. This would mean the buildbot would go red if things fail to import. What do you all think? jml
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 We just ran into this today with Athena tests. It's actually easy to write a test that just imports everything once, but nobody seems to ever do that. Having an import failure show up somewhere in the test summary is pretty important. C Jonathan Lange wrote:
Hello,
For a while I've been thinking of changing Trial so that import errors flag the test suite as failed. This would mean the buildbot would go red if things fail to import.
What do you all think?
jml
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDq5wy3A5SrXAiHQcRApnDAJ472YMWIq/KTEdiztZ1MPbu5WTWAwCfc3en Z8go682s3sH8HOaqBohBpvE= =iFqr -----END PGP SIGNATURE-----
On 12/23/05, Cory Dodt <corydodt@twistedmatrix.com> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
We just ran into this today with Athena tests. It's actually easy to write a test that just imports everything once, but nobody seems to ever do that. Having an import failure show up somewhere in the test summary is pretty important.
Import failures show up in the test summary. They just don't flag the suite as failed. In this way, they are similar to skipped tests. jml
On Fri, 23 Dec 2005 17:05:19 +1100, Jonathan Lange <jml@mumak.net> wrote:
Hello,
For a while I've been thinking of changing Trial so that import errors flag the test suite as failed. This would mean the buildbot would go red if things fail to import.
What do you all think?
Yes. DEFINITELY. I'd go so far as to say that this is simply a bug, and I don't care if anyone disagrees - you should go ahead.
participants (3)
-
Cory Dodt -
glyph＠divmod.com -
Jonathan Lange