[Twisted-Python] Incremental vs. Black
Hi all, I opened https://github.com/twisted/incremental/issues/55 a few days ago, and I'm wondering if anyone has any objection to me making a fix. I'm using incremental at work on a project that uses black, so this just means I have to run black each time there is a version update -- not the end of the world, but annoying nonetheless. Moshe Z.
On Saturday, 1 August 2020 18:14:15 BST Moshe Zadka wrote:
Hi all,
I opened https://github.com/twisted/incremental/issues/55 a few days ago, and I'm wondering if anyone has any objection to me making a fix. I'm using incremental at work on a project that uses black, so this just means I have to run black each time there is a version update -- not the end of the world, but annoying nonetheless.
Surely its not appropriate to run black on third party code? Why not tell black to ignore it? Barry
Moshe Z.
On Mon, Aug 10, 2020, at 07:29, Barry Scott wrote:
On Saturday, 1 August 2020 18:14:15 BST Moshe Zadka wrote:
Hi all,
I opened https://github.com/twisted/incremental/issues/55 a few days ago, and I'm wondering if anyone has any objection to me making a fix. I'm using incremental at work on a project that uses black, so this just means I have to run black each time there is a version update -- not the end of the world, but annoying nonetheless.
Surely its not appropriate to run black on third party code?
Because `_version.py` is designed to be checked in to your code, is reviewed in a PR along with other code, etc. Moshe Z.
participants (2)
-
Barry Scott
-
Moshe Zadka