[Twisted-Python] How do I write AMP Command definitions TTD-edly?
Hi, I have no issue writing AMP responders TTD-edly, they work pretty much the way any other code would. However, I did notice that the only way I'd notice if my Command definitions themselves were broken were if my functional tests start failing. It would be nice if I could write unit test driven Command specifications, as well. The quickest I could come up with was to call makeArguments/makeResponse with a few known-good/known-bad dictionaries, and see if it blows up. Is there a smarter way to do it? -- cheers lvh
On 03:34 pm, _@lvh.cc wrote:
Hi,
I have no issue writing AMP responders TTD-edly, they work pretty much the way any other code would. However, I did notice that the only way I'd notice if my Command definitions themselves were broken were if my functional tests start failing.
Chris and I wrote all the AMP-using code for game TDD. See game/test/test_network.py in lp:game. Jean-Paul
It would be nice if I could write unit test driven Command specifications, as well.
The quickest I could come up with was to call makeArguments/makeResponse with a few known-good/known-bad dictionaries, and see if it blows up. Is there a smarter way to do it?
-- cheers lvh
On Mar 4, 2013, at 8:17 AM, exarkun@twistedmatrix.com wrote:
Chris and I wrote all the AMP-using code for game TDD. See game/test/test_network.py in lp:game.
(That's <http://bazaar.launchpad.net/~game-hackers/game/trunk/view/head:/game/test/te...> for those of you not familiar with launchpad.) -g
That looks awesome. I can't find a license for it. I'm publishing some third-party helpers for twisted's amp implementation as I need them myself (presumably I'll make a formal release announcement at the Pycon sprints). Do you mind if I copy this code? I can't seem to find a license. (txampext is ISC-licensed, which I assume is congruent to your sensibilities :)) On Mon, Mar 4, 2013 at 5:17 PM, <exarkun@twistedmatrix.com> wrote:
On 03:34 pm, _@lvh.cc wrote:
Hi,
I have no issue writing AMP responders TTD-edly, they work pretty much the way any other code would. However, I did notice that the only way I'd notice if my Command definitions themselves were broken were if my functional tests start failing.
Chris and I wrote all the AMP-using code for game TDD. See game/test/test_network.py in lp:game.
Jean-Paul
It would be nice if I could write unit test driven Command specifications, as well.
The quickest I could come up with was to call makeArguments/makeResponse with a few known-good/known-bad dictionaries, and see if it blows up. Is there a smarter way to do it?
-- cheers lvh
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-- cheers lvh
On 5 Mar, 09:46 am, _@lvh.cc wrote:
That looks awesome.
I can't find a license for it.
The code was already MIT licensed. It's more redundantly so, now. Jean-Paul I'm publishing some third-party helpers for
twisted's amp implementation as I need them myself (presumably I'll make a formal release announcement at the Pycon sprints). Do you mind if I copy this code? I can't seem to find a license. (txampext is ISC-licensed, which I assume is congruent to your sensibilities :))
On Mon, Mar 4, 2013 at 5:17 PM, <exarkun@twistedmatrix.com> wrote:
On 03:34 pm, _@lvh.cc wrote:
Hi,
I have no issue writing AMP responders TTD-edly, they work pretty much the way any other code would. However, I did notice that the only way I'd notice if my Command definitions themselves were broken were if my functional tests start failing.
Chris and I wrote all the AMP-using code for game TDD. See game/test/test_network.py in lp:game.
Jean-Paul
It would be nice if I could write unit test driven Command specifications, as well.
The quickest I could come up with was to call makeArguments/makeResponse with a few known-good/known-bad dictionaries, and see if it blows up. Is there a smarter way to do it?
-- cheers lvh
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-- cheers lvh
Awesome, thanks! On Mar 6, 2013 5:18 PM, <exarkun@twistedmatrix.com> wrote:
On 5 Mar, 09:46 am, _@lvh.cc wrote:
That looks awesome.
I can't find a license for it.
The code was already MIT licensed. It's more redundantly so, now.
Jean-Paul
I'm publishing some third-party helpers for
twisted's amp implementation as I need them myself (presumably I'll make a formal release announcement at the Pycon sprints). Do you mind if I copy this code? I can't seem to find a license. (txampext is ISC-licensed, which I assume is congruent to your sensibilities :))
On Mon, Mar 4, 2013 at 5:17 PM, <exarkun@twistedmatrix.com> wrote:
On 03:34 pm, _@lvh.cc wrote:
Hi,
I have no issue writing AMP responders TTD-edly, they work pretty much the way any other code would. However, I did notice that the only way I'd notice if my Command definitions themselves were broken were if my functional tests start failing.
Chris and I wrote all the AMP-using code for game TDD. See game/test/test_network.py in lp:game.
Jean-Paul
It would be nice if I could write unit test driven Command specifications, as well.
The quickest I could come up with was to call makeArguments/makeResponse with a few known-good/known-bad dictionaries, and see if it blows up. Is there a smarter way to do it?
-- cheers lvh
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-- cheers lvh
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Hi again, Sorry to drag up this old post, but I have another question. On Mon, Mar 4, 2013 at 5:17 PM, <exarkun@twistedmatrix.com> wrote:
Chris and I wrote all the AMP-using code for game TDD. See game/test/test_network.py in lp:game.
I've implemented this in txampext.commandtests: https://github.com/lvh/txampext/blob/master/txampext/commandtests.py There's one more issue I have though. The lp:game code (and now txampext) deals with arguments and responses, but not exceptions. Did you have something pleasant for that, or should I just hack the the equivalent thing together for AMP exceptions as well? cheers lvh
participants (4)
-
exarkun＠twistedmatrix.com -
Glyph -
Laurens Van Houtven -
Laurens Van Houtven