[Twisted-Python] twisted.web.error.Error & BaseException.message deprecation
Hi Guys, Been seeing this error for a long time and finally getting off my bum to see about fixing it: twisted/web/error.py:53: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 It looks like the issue is the "self.message = message" assignment in __init__: https://gist.github.com/865097 Before I go about getting rid of the warning, does anyone have a reason Error.message should stick around? -J
On Mar 10, 2011, at 5:45 PM, Jason J. W. Williams wrote:
Hi Guys,
Been seeing this error for a long time and finally getting off my bum to see about fixing it:
twisted/web/error.py:53: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
It looks like the issue is the "self.message = message" assignment in __init__: https://gist.github.com/865097
Before I go about getting rid of the warning, does anyone have a reason Error.message should stick around?
This is the attribute used (in some cases) to relay the protocol-level error message printed in the status line area of the HTTP response. So yes, we need to keep it; it doesn't mean the same thing as Python's earlier 'message' attribute on Exception. If we can simply squash the warning that would be best.
Setting it as a class level attribute seems to suppress it:
class TestError(Exception): ... message = "" ... ... def __init__(self, msg): ... self.message = msg
Since it's a string and passed by value I think this would work. I'll open up a ticket if one's not already. -J On Thu, Mar 10, 2011 at 10:12 PM, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:
On Mar 10, 2011, at 5:45 PM, Jason J. W. Williams wrote:
Hi Guys,
Been seeing this error for a long time and finally getting off my bum to see about fixing it:
twisted/web/error.py:53: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
It looks like the issue is the "self.message = message" assignment in __init__: https://gist.github.com/865097
Before I go about getting rid of the warning, does anyone have a reason Error.message should stick around?
This is the attribute used (in some cases) to relay the protocol-level error message printed in the status line area of the HTTP response. So yes, we need to keep it; it doesn't mean the same thing as Python's earlier 'message' attribute on Exception. If we can simply squash the warning that would be best.
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On Mar 11, 2011, at 2:25 AM, Jason J. W. Williams wrote:
Setting it as a class level attribute seems to suppress it:
class TestError(Exception): ... message = "" ... ... def __init__(self, msg): ... self.message = msg
Since it's a string and passed by value I think this would work. I'll open up a ticket if one's not already.
Sounds good. I can't find one, but there have been other tickets with a similar purpose ('message' attributes on other exceptions). If you have time after fixing this issue, it would be nice if you could double-check that there aren't any more of these lurking around :).
Hi Glyph, I re-opened 4456 and attached a patch. I think that's this issue. The only other one I found in the tickets was for Conch and that one was marked fixed. -J Sent via iPhone Is your e-mail Premiere? On Mar 11, 2011, at 9:51, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:
On Mar 11, 2011, at 2:25 AM, Jason J. W. Williams wrote:
Setting it as a class level attribute seems to suppress it:
class TestError(Exception): ... message = "" ... ... def __init__(self, msg): ... self.message = msg
Since it's a string and passed by value I think this would work. I'll open up a ticket if one's not already.
Sounds good. I can't find one, but there have been other tickets with a similar purpose ('message' attributes on other exceptions).
If you have time after fixing this issue, it would be nice if you could double-check that there aren't any more of these lurking around :).
On Mar 11, 2011, at 12:52 PM, Jason J. W. Williams wrote:
Hi Glyph,
I re-opened 4456 and attached a patch. I think that's this issue. The only other one I found in the tickets was for Conch and that one was marked fixed.
Thanks! At the latest, this should get reviewed at the sprint. -glyph
Pleasure. :) -J On Fri, Mar 11, 2011 at 2:28 PM, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:
On Mar 11, 2011, at 12:52 PM, Jason J. W. Williams wrote:
Hi Glyph,
I re-opened 4456 and attached a patch. I think that's this issue. The only other one I found in the tickets was for Conch and that one was marked fixed.
Thanks! At the latest, this should get reviewed at the sprint.
-glyph
participants (2)
-
Glyph Lefkowitz -
Jason J. W. Williams