On behalf of the Twisted contributors I announce the release candidate of Twisted 21.7.0
This is mostly a bugfix release.
*Python 3.5 is no longer a supported platform.* *The minimum supported platform is Python 3.6.7.*
The notable features are:
- Python 3.10 beta is now a supported platform. - twisted.web.template.renderElement() now accepts any IRequest implementer instead of only twisted.web.server.Request. Add type hints to twisted.web.template. (#10184)
The release and NEWS file is available for review at
https://github.com/twisted/twisted/pull/1614/files
Release candidate documentation is available at
https://twisted--1614.org.readthedocs.build/en/1614/
Wheels for the release candidate are available on PyPI
https://pypi.org/project/Twisted/21.7.0rc1/
python -m pip install Twisted==21.7.0rc1
Please test it and report any issues. If nothing comes up in 1 week, 21.7.0 will be released based on the latest release candidate.
Many thanks to everyone who had a part in Twisted - the supporters of the Twisted Software Foundation, the developers, and all the people testing and building great things with Twisted!
Thank you Adi! Very glad to see us collectively getting back on the release-management horse again! And it was super encouraging to see how quickly you were able to get this out, with all the automation that everyone (not least of all yourself) has been building to make this process faster and simpler.
It appears we've buried the lede on one of our biggest features in this release though - https://github.com/twisted/twisted/pull/1448/files https://github.com/twisted/twisted/pull/1448/files had no newsfile that shows up in the changelog, but it properly made Deferred into a generic, so I think this is the first release of Twisted where you might reasonably be able to use mypy without your own custom stub files! :)
-g
On Jul 10, 2021, at 4:50 AM, Adi Roiban adi@roiban.ro wrote:
On behalf of the Twisted contributors I announce the release candidate of Twisted 21.7.0
This is mostly a bugfix release.
Python 3.5 is no longer a supported platform. The minimum supported platform is Python 3.6.7.
The notable features are:
- Python 3.10 beta is now a supported platform.
- twisted.web.template.renderElement() now accepts any IRequest implementer instead of only twisted.web.server.Request. Add type hints to twisted.web.template. (#10184)
The release and NEWS file is available for review at
https://github.com/twisted/twisted/pull/1614/files <https://github.com/twisted/twisted/pull/1614/files>Release candidate documentation is available at
https://twisted--1614.org.readthedocs.build/en/1614/ <https://twisted--1614.org.readthedocs.build/en/1614/>Wheels for the release candidate are available on PyPI
https://pypi.org/project/Twisted/21.7.0rc1/ <https://pypi.org/project/Twisted/21.7.0rc1/> python -m pip install Twisted==21.7.0rc1Please test it and report any issues. If nothing comes up in 1 week, 21.7.0 will be released based on the latest release candidate.
Many thanks to everyone who had a part in Twisted - the supporters of the Twisted Software Foundation, the developers, and all the people testing and building great things with Twisted!
-- Adi Roiban _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On Sun, 11 Jul 2021 at 00:49, Glyph glyph@twistedmatrix.com wrote:
Thank you Adi! Very glad to see us collectively getting back on the release-management horse again! And it was super encouraging to see how quickly you were able to get this out, with all the automation that everyone (not least of all yourself) has been building to make this process faster and simpler.
It appears we've buried the lede on one of our biggest features in this release though - https://github.com/twisted/twisted/pull/1448/files had no newsfile that shows up in the changelog, but it properly made Deferred into a generic, so I think this is the first release of Twisted where you might *reasonably* be able to use mypy without your own custom stub files! :)
Thanks Glyph and Thomas and Tom for the release notes feedback.
I was thinking that 21.7.0 is ready for the final review.
PR at https://github.com/twisted/twisted/pull/1614
I am doing some fast-tracking here (as I now have some time)
But while writing this email, the python 3.8 and 3.9 version on GitHub VMs were updates and we now have broken tests in trunk and in the release branch
The release blocking ticket was created at https://twistedmatrix.com/trac/ticket/10230
Please see if you can help with unlocking the release. Thomas is already helping. Either fix the issue, or decide if it's ok to release with this issue.
There was also another minor idna pypy update release blocker that was already fixed by Thomas.
I was planning to push the final release on Saturday 17 of July, to allow for a full 1 week of feedback for the release candidate.
---------
There is also a PR for updating the release docs - https://github.com/twisted/twisted/pull/1616
Regards
On 11/07/2021 00:49, Glyph wrote:
Thank you Adi! Very glad to see us collectively getting back on the release-management horse again! And it was super encouraging to see how quickly you were able to get this out, with all the automation that everyone (not least of all yourself) has been building to make this process faster and simpler.
To echo this: thank you for your work, Adi!
It appears we've buried the lede on one of our biggest features in this release though - https://github.com/twisted/twisted/pull/1448/files https://github.com/twisted/twisted/pull/1448/files had no newsfile that shows up in the changelog, but it properly made Deferred into a generic, so I think this is the first release of Twisted where you might /reasonably/ be able to use mypy without your own custom stub files! :)
This looks very cool, but presents us with a problem.
mypy now complains about instantiations of Deferred without a type annotation:
d = defer.Deferred()
results in an error:
synapse/util/async_helpers.py:124: error: Need type annotation for
'd' [var-annotated]
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
On Thursday, 15 July 2021 17:00:06 BST Richard van der Hoff wrote:
On 11/07/2021 00:49, Glyph wrote:
Thank you Adi! Very glad to see us collectively getting back on the release-management horse again! And it was super encouraging to see how quickly you were able to get this out, with all the automation that everyone (not least of all yourself) has been building to make this process faster and simpler.
To echo this: thank you for your work, Adi!
It appears we've buried the lede on one of our biggest features in this release though - https://github.com/twisted/twisted/pull/1448/files https://github.com/twisted/twisted/pull/1448/files had no newsfile that shows up in the changelog, but it properly made Deferred into a generic, so I think this is the first release of Twisted where you might /reasonably/ be able to use mypy without your own custom stub files! :)
This looks very cool, but presents us with a problem.
mypy now complains about instantiations of Deferred without a type annotation:
d = defer.Deferred()
results in an error:
synapse/util/async_helpers.py:124: error: Need type annotation for
'd' [var-annotated]
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
What is the minimum version of Python 3 that is supported? Does that minimum versions not have the typing feature that is used?
Also I thought that mypy could imply the type of d from the assignment. Or is that that it could later...
Disclaimer, my mypy use is not that deep yet.
Barry
On Thu, 15 Jul 2021 at 17:02, Richard van der Hoff richard@matrix.org wrote:
On 11/07/2021 00:49, Glyph wrote:
Thank you Adi! Very glad to see us collectively getting back on the release-management horse again! And it was super encouraging to see how quickly you were able to get this out, with all the automation that everyone (not least of all yourself) has been building to make this process faster and simpler.
To echo this: thank you for your work, Adi!
It appears we've buried the lede on one of our biggest features in this release though - https://github.com/twisted/twisted/pull/1448/files had no newsfile that shows up in the changelog, but it properly made Deferred into a generic, so I think this is the first release of Twisted where you might *reasonably* be able to use mypy without your own custom stub files! :)
This looks very cool, but presents us with a problem.
mypy now complains about instantiations of Deferred without a type annotation:
d = defer.Deferred()
results in an error:
synapse/util/async_helpers.py:124: error: Need type annotation for 'd'
[var-annotated]
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
I also don't have much experience with mypy, but I guess that you can ignore the errors from twisted.internet.defer via mypy.ini
[mypy-twisted.internet.defer] allow_untyped_defs = True
On Jul 15, 2021, at 9:00 AM, Richard van der Hoff richard@matrix.org wrote:
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
Are you saying you need it to typecheck against older versions or just run against them?
-g
On 16/07/2021 00:18, Glyph wrote:
On Jul 15, 2021, at 9:00 AM, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
Are you saying you need it to typecheck against older versions or just run against them?
Ah, this gave me the clue I needed. We just need to run against them. Which means I can put type hints in comments, where they will be ignored at runtime. It's fiddly, but it will work well enough.
Thanks Glyph, and thanks to Adi and Barry for your suggestions too.
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
On Jul 16, 2021, at 2:20 AM, Richard van der Hoff richard@matrix.org wrote:
On 16/07/2021 00:18, Glyph wrote:
On Jul 15, 2021, at 9:00 AM, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
Are you saying you need it to typecheck against older versions or just run against them?
Ah, this gave me the clue I needed. We just need to run against them. Which means I can put type hints in comments, where they will be ignored at runtime. It's fiddly, but it will work well enough.
You can also do 'from __future__ import annotations' to avoid the annotations getting evaluated, which might be slightly less awkward.
Thanks Glyph, and thanks to Adi and Barry for your suggestions too.
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
This definitely looks wrong; there should be a TypeVar in there. Adi, I'd go so far as to say that this should be a release blocker, although the change should be fairly minimal.
Richard, could you please make a proper PR for this to get CI kicked off and make sure the new annotation doesn't cause any failures?
-g
On Fri, 16 Jul 2021 at 20:27, Glyph glyph@twistedmatrix.com wrote:
On Jul 16, 2021, at 2:20 AM, Richard van der Hoff richard@matrix.org wrote:
On 16/07/2021 00:18, Glyph wrote:
On Jul 15, 2021, at 9:00 AM, Richard van der Hoff richard@matrix.org wrote:
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
Are you saying you need it to typecheck against older versions or just run against them?
Ah, this gave me the clue I needed. We just need to run against them. Which means I can put type hints in comments, where they will be ignored at runtime. It's fiddly, but it will work well enough.
You can also do 'from __future__ import annotations' to avoid the annotations getting evaluated, which might be slightly less awkward.
Thanks Glyph, and thanks to Adi and Barry for your suggestions too.
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
This definitely looks wrong; there should be a TypeVar in there. Adi, I'd go so far as to say that this should be a release blocker, although the change should be fairly minimal.
Richard, could you please make a proper PR for this to get CI kicked off and make sure the new annotation doesn't cause any failures?
I think that I will do a RC2 release candidate, since due to this issue the GHA tests on RC1 are red - https://github.com/twisted/twisted/pull/1628 So I plan to cherry-pick those changes and do a RC2.
Regarding the release blocker, I will block the release for any ticket from https://twistedmatrix.com/trac/report/26
Right now, I have added https://twistedmatrix.com/trac/ticket/10231 to that report.
So, if anyone knows how to fix https://twistedmatrix.com/trac/ticket/10231 please help to unblock the release.
Or if you think that https://twistedmatrix.com/trac/ticket/10231 should not be a release blocker, please add your comments.
For now, I will delay the release of RC2 to wait to see what is the resolution for #10231
Regards
On Jul 17, 2021, at 3:47 AM, Adi Roiban adiroiban@gmail.com wrote:
On Fri, 16 Jul 2021 at 20:27, Glyph <glyph@twistedmatrix.com mailto:glyph@twistedmatrix.com> wrote:
On Jul 16, 2021, at 2:20 AM, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
On 16/07/2021 00:18, Glyph wrote:
On Jul 15, 2021, at 9:00 AM, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
We can't just go and add type annotations because we need to maintain compatibility with older Twisted (to make it possible to package in Debian et al).
Any suggestions for keeping mypy happy?
Are you saying you need it to typecheck against older versions or just run against them?
Ah, this gave me the clue I needed. We just need to run against them. Which means I can put type hints in comments, where they will be ignored at runtime. It's fiddly, but it will work well enough.
You can also do 'from __future__ import annotations' to avoid the annotations getting evaluated, which might be slightly less awkward.
Thanks Glyph, and thanks to Adi and Barry for your suggestions too.
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
This definitely looks wrong; there should be a TypeVar in there. Adi, I'd go so far as to say that this should be a release blocker, although the change should be fairly minimal.
Richard, could you please make a proper PR for this to get CI kicked off and make sure the new annotation doesn't cause any failures?
I think that I will do a RC2 release candidate, since due to this issue the GHA tests on RC1 are red - https://github.com/twisted/twisted/pull/1628 https://github.com/twisted/twisted/pull/1628 So I plan to cherry-pick those changes and do a RC2.
Regarding the release blocker, I will block the release for any ticket from https://twistedmatrix.com/trac/report/26 https://twistedmatrix.com/trac/report/26
Right now, I have added https://twistedmatrix.com/trac/ticket/10231 https://twistedmatrix.com/trac/ticket/10231 to that report.
So, if anyone knows how to fix https://twistedmatrix.com/trac/ticket/10231 https://twistedmatrix.com/trac/ticket/10231 please help to unblock the release.
Or if you think that https://twistedmatrix.com/trac/ticket/10231 https://twistedmatrix.com/trac/ticket/10231 should not be a release blocker, please add your comments.
For now, I will delay the release of RC2 to wait to see what is the resolution for #10231
This depends largely upon your available time and the difficulty of making these changes, but I'd suggest doing an RC2 as soon as the fixes are ready for the new python versions, to ensure folks can test with those, and then do an RC3 as soon as the annotation fix is ready.
-g
On 16/07/2021 20:27, Glyph wrote:
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
This definitely looks wrong; there should be a TypeVar in there. Adi, I'd go so far as to say that this should be a release blocker, although the change should be fairly minimal.
Richard, could you please make a proper PR for this to get CI kicked off and make sure the new annotation doesn't cause any failures?
Done, in the form of https://github.com/twisted/twisted/pull/1632.
Hi guys
I'm new to twisted and would appreciate some beginner guidance.
I'm trying to use the "python -m twisted.conch.stdio" command in command prompt but it does not work and gives the following error:
C:\WINDOWS\system32>python -m twisted.conch C:\Users\Melanie\AppData\Local\Microsoft\WindowsApps\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\python.exe: No module named twisted.conch.*main*; 'twisted.conch' is a package and cannot be directly executed
*I'm hoping that this will solve the rest of the error messages I'm having. I want to eventually be ably to run :*
from twisted.names import client client.getHostByName('www.example.com')
<Deferred at 0xf5c5a8 waiting on Deferred at 0xf5cb90>
_
<Deferred at 0xf5c5a8 current result: '2606:2800:220:6d:26bf:1447:1097:aa7'>
client.lookupMailExchange('twistedmatrix.com')
<Deferred at 0xf5cd40 waiting on Deferred at 0xf5cea8>
_
<Deferred at 0xf5cd40 current result: ([<RR name=twistedmatrix.com type=MX class=IN ttl=1s auth=False>], [], [])>
*The aim is to get the deferred responses as shown in previous code, but all I get is:*
from twisted.names import client client.getHostByName('www.example.com')
<Deferred at 0x263d27b9dc8 waiting on Deferred at 0x263d27b9f48>
_
<Deferred at 0x263d27b9dc8 waiting on Deferred at 0x263d27b9f48>
client.lookupMailExchange('twistedmatrix.com')
<Deferred at 0x263d27c6a88 waiting on Deferred at 0x263d27c6c08>
_
<Deferred at 0x263d27c6a88 waiting on Deferred at 0x263d27c6c08>
Please help. I'm trying to send this to the twisted mailing group. If I'm wrong please nudge me in the right direction.
Thanks in advance.
M
On Mon, Jul 19, 2021 at 12:43 AM Richard van der Hoff richard@matrix.org wrote:
On 16/07/2021 20:27, Glyph wrote:
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
This definitely looks wrong; there should be a TypeVar in there. Adi, I'd go so far as to say that this should be a release blocker, although the change should be fairly minimal.
Richard, could you please make a proper PR for this to get CI kicked off and make sure the new annotation doesn't cause any failures?
Done, in the form of https://github.com/twisted/twisted/pull/1632.
Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On Jul 18, 2021, at 11:39 PM, Melanie Molifie mmolifie@gmail.com wrote:
Hi guys
I'm new to twisted and would appreciate some beginner guidance.
Hi Melanie! Welcome to the community. I hope we can get you set up better.
I'm trying to use the "python -m twisted.conch.stdio" command in command prompt but it does not work and gives the following error:
C:\WINDOWS\system32>python -m twisted.conch C:\Users\Melanie\AppData\Local\Microsoft\WindowsApps\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\python.exe: No module named twisted.conch.main; 'twisted.conch' is a package and cannot be directly executed
In this example you're doing `python -m twisted.conch`, not `python -m twisted.conch.stdio`, which will not work anywhere. Unfortunately, the Conch standard-IO library (and therefore the conch terminal client, and twisted.conch.stdio) doesn't work on Windows and never has: https://twistedmatrix.com/trac/ticket/2157 https://twistedmatrix.com/trac/ticket/2157. However, you may be able to get it up and running with the Windows Subsystem for Linux, which I believe will present a Linux-like interface since as far as the application knows it's running on Linux: https://docs.microsoft.com/en-us/windows/wsl/about https://docs.microsoft.com/en-us/windows/wsl/about
I'm hoping that this will solve the rest of the error messages I'm having. I want to eventually be ably to run :
from twisted.names import client client.getHostByName('www.example.com http://www.example.com/')
<Deferred at 0xf5c5a8 waiting on Deferred at 0xf5cb90>
_
<Deferred at 0xf5c5a8 current result: '2606:2800:220:6d:26bf:1447:1097:aa7'>
client.lookupMailExchange('twistedmatrix.com http://twistedmatrix.com/')
<Deferred at 0xf5cd40 waiting on Deferred at 0xf5cea8>
_
<Deferred at 0xf5cd40 current result: ([<RR name=twistedmatrix.com http://twistedmatrix.com/ type=MX class=IN ttl=1s auth=False>], [], [])>
Is the goal here specifically to do this with Conch, or would doing it with Jupyter Notebook (using something like https://twitter.com/glyph/status/1417360623818575876 https://twitter.com/glyph/status/1417360623818575876 which I found while researching a response to this email!) be sufficient?
Or, for that matter, could you just write a little program? A sample Python script that runs the reactor is probably easier to set up than a reactor-enabled REPL, particularly on Windows. (There are various options for a reactor-enabled REPL, it's definitely doable, but it might be a bit rough as a first step; as you're discovering.)
The aim is to get the deferred responses as shown in previous code, but all I get is:
from twisted.names import client client.getHostByName('www.example.com http://www.example.com/')
<Deferred at 0x263d27b9dc8 waiting on Deferred at 0x263d27b9f48>
_
<Deferred at 0x263d27b9dc8 waiting on Deferred at 0x263d27b9f48>
client.lookupMailExchange('twistedmatrix.com http://twistedmatrix.com/')
<Deferred at 0x263d27c6a88 waiting on Deferred at 0x263d27c6c08>
_
<Deferred at 0x263d27c6a88 waiting on Deferred at 0x263d27c6c08>
The reason you're getting this with a normal Python interactive interpreter is that the event loop which actually performs the I/O (does the DNS queries, in this case) isn't running at all, so the Deferreds are created, but never resolved.
Please help. I'm trying to send this to the twisted mailing group. If I'm wrong please nudge me in the right direction.
This is as good a place as any :).
Thanks in advance.
M
On Mon, Jul 19, 2021 at 12:43 AM Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote: On 16/07/2021 20:27, Glyph wrote:
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
This definitely looks wrong; there should be a TypeVar in there. Adi, I'd go so far as to say that this should be a release blocker, although the change should be fairly minimal.
Richard, could you please make a proper PR for this to get CI kicked off and make sure the new annotation doesn't cause any failures?
Done, in the form of https://github.com/twisted/twisted/pull/1632 https://github.com/twisted/twisted/pull/1632.
Twisted-Python mailing list Twisted-Python@twistedmatrix.com mailto:Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
On Sun, 18 Jul 2021 at 23:42, Richard van der Hoff richard@matrix.org wrote:
On 16/07/2021 20:27, Glyph wrote:
One particular problem I came across was the type annotation on inlineCallbacks. I've filed https://twistedmatrix.com/trac/ticket/10231 about it - would appreciate thoughts.
This definitely looks wrong; there should be a TypeVar in there. Adi, I'd go so far as to say that this should be a release blocker, although the change should be fairly minimal.
Richard, could you please make a proper PR for this to get CI kicked off and make sure the new annotation doesn't cause any failures?
Done, in the form of https://github.com/twisted/twisted/pull/1632.
Hi
Thanks to Thomas and Richard 21.7.0 RC2 was released.
Release notes https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2
PyPy page https://pypi.org/project/Twisted/21.7.0rc2/
Please test and send any issue over email or GitHub Pull request at https://github.com/twisted/twisted/pull/1614
If all is ok, I plan to do the final release by the end of Friday or during the weekend.
Hi all,
I just finally got around to installing and testing the new RC with our primary Twisted App. Everything seems to work fine.
I continue to be impressed by what a good job Twisted does with backwards compatibility!
-- John Santos
On 7/20/2021 7:23 PM, Adi Roiban wrote:
On Sun, 18 Jul 2021 at 23:42, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
On 16/07/2021 20:27, Glyph wrote: > >> One particular problem I came across was the type annotation on >> inlineCallbacks. I've filed >> https://twistedmatrix.com/trac/ticket/10231 <https://twistedmatrix.com/trac/ticket/10231> about it - would >> appreciate thoughts. >> > This definitely looks wrong; there should be a TypeVar in there. Adi, > I'd go so far as to say that this should be a release blocker, > although the change should be fairly minimal. > > Richard, could you please make a proper PR for this to get CI kicked > off and make sure the new annotation doesn't cause any failures? Done, in the form of https://github.com/twisted/twisted/pull/1632 <https://github.com/twisted/twisted/pull/1632>.Hi
Thanks to Thomas and Richard 21.7.0 RC2 was released.
Release notes https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2 https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2
PyPy page https://pypi.org/project/Twisted/21.7.0rc2/ https://pypi.org/project/Twisted/21.7.0rc2/
Please test and send any issue over email or GitHub Pull request at https://github.com/twisted/twisted/pull/1614 https://github.com/twisted/twisted/pull/1614
If all is ok, I plan to do the final release by the end of Friday or during the weekend.
-- Adi Roiban
Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Hi,
Thanks for all of you who have sent comments and fixes for RC2.
The third release candidate is available for download and testing
https://pypi.org/project/Twisted/21.7.0rc3/#files
https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc3
This contains 2 changes:
The wheel file is now published to PyPi.
The following revert was done:
* The ticket in which the regression was reported https://twistedmatrix.com/trac/ticket/10235 * Reverted ticket https://twistedmatrix.com/trac/ticket/10155 * Reverted PR https://github.com/twisted/twisted/pull/1570
--------------
You can send your comments over email or over GitHub
https://github.com/twisted/twisted/pull/1614
I plan to do the final release by the end of Sunday UTC time.
Regards
On Wed, 21 Jul 2021 at 19:07, John Santos john@egh.com wrote:
Hi all,
I just finally got around to installing and testing the new RC with our primary Twisted App. Everything seems to work fine.
I continue to be impressed by what a good job Twisted does with backwards compatibility!
-- John Santos
On 7/20/2021 7:23 PM, Adi Roiban wrote:
On Sun, 18 Jul 2021 at 23:42, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
On 16/07/2021 20:27, Glyph wrote: > >> One particular problem I came across was the type annotation on >> inlineCallbacks. I've filed >> https://twistedmatrix.com/trac/ticket/10231 <https://twistedmatrix.com/trac/ticket/10231> about it - would >> appreciate thoughts. >> > This definitely looks wrong; there should be a TypeVar in there.Adi,
> I'd go so far as to say that this should be a release blocker, > although the change should be fairly minimal. > > Richard, could you please make a proper PR for this to get CIkicked
> off and make sure the new annotation doesn't cause any failures? Done, in the form of https://github.com/twisted/twisted/pull/1632 <https://github.com/twisted/twisted/pull/1632>.Hi
Thanks to Thomas and Richard 21.7.0 RC2 was released.
Release notes https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2 https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2
PyPy page https://pypi.org/project/Twisted/21.7.0rc2/ https://pypi.org/project/Twisted/21.7.0rc2/
Please test and send any issue over email or GitHub Pull request at https://github.com/twisted/twisted/pull/1614 https://github.com/twisted/twisted/pull/1614
If all is ok, I plan to do the final release by the end of Friday or
during the
weekend.
-- Adi Roiban
Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-- John Santos Evans Griffiths & Hart, Inc. 781-861-0670 ext 539
Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Hi
Just a quick update. The release is on hold as I am waiting for Thomas to check a possible regression.
I don't know when the results from the investigation will be available. I hope for the end of today.
Will be back with more details. Cheers
On Fri, 23 Jul 2021, 10:55 Adi Roiban, adiroiban@gmail.com wrote:
Hi,
Thanks for all of you who have sent comments and fixes for RC2.
The third release candidate is available for download and testing
https://pypi.org/project/Twisted/21.7.0rc3/#files
https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc3
This contains 2 changes:
The wheel file is now published to PyPi.
The following revert was done:
- The ticket in which the regression was reported
https://twistedmatrix.com/trac/ticket/10235
- Reverted ticket https://twistedmatrix.com/trac/ticket/10155
- Reverted PR https://github.com/twisted/twisted/pull/1570
You can send your comments over email or over GitHub
https://github.com/twisted/twisted/pull/1614
I plan to do the final release by the end of Sunday UTC time.
Regards
On Wed, 21 Jul 2021 at 19:07, John Santos john@egh.com wrote:
Hi all,
I just finally got around to installing and testing the new RC with our primary Twisted App. Everything seems to work fine.
I continue to be impressed by what a good job Twisted does with backwards compatibility!
-- John Santos
On 7/20/2021 7:23 PM, Adi Roiban wrote:
On Sun, 18 Jul 2021 at 23:42, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
On 16/07/2021 20:27, Glyph wrote: > >> One particular problem I came across was the type annotation on >> inlineCallbacks. I've filed >> https://twistedmatrix.com/trac/ticket/10231 <https://twistedmatrix.com/trac/ticket/10231> about it - would >> appreciate thoughts. >> > This definitely looks wrong; there should be a TypeVar inthere. Adi,
> I'd go so far as to say that this should be a release blocker, > although the change should be fairly minimal. > > Richard, could you please make a proper PR for this to get CIkicked
> off and make sure the new annotation doesn't cause any failures? Done, in the form of https://github.com/twisted/twisted/pull/1632 <https://github.com/twisted/twisted/pull/1632>.Hi
Thanks to Thomas and Richard 21.7.0 RC2 was released.
Release notes https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2 https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2
PyPy page https://pypi.org/project/Twisted/21.7.0rc2/ https://pypi.org/project/Twisted/21.7.0rc2/
Please test and send any issue over email or GitHub Pull request at https://github.com/twisted/twisted/pull/1614 https://github.com/twisted/twisted/pull/1614
If all is ok, I plan to do the final release by the end of Friday or
during the
weekend.
-- Adi Roiban
Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-- John Santos Evans Griffiths & Hart, Inc. 781-861-0670 ext 539
Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-- Adi Roiban
On Mon, 26 Jul 2021 at 06:57, Adi Roiban adiroiban@gmail.com wrote:
Hi
Just a quick update. The release is on hold as I am waiting for Thomas to check a possible regression.
I don't know when the results from the investigation will be available. I hope for the end of today.
Will be back with more details. Cheers
On Fri, 23 Jul 2021, 10:55 Adi Roiban, adiroiban@gmail.com wrote:
Hi,
Thanks for all of you who have sent comments and fixes for RC2.
The third release candidate is available for download and testing
https://pypi.org/project/Twisted/21.7.0rc3/#files
https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc3
This contains 2 changes:
The wheel file is now published to PyPi.
The following revert was done:
- The ticket in which the regression was reported
https://twistedmatrix.com/trac/ticket/10235
- Reverted ticket https://twistedmatrix.com/trac/ticket/10155
- Reverted PR https://github.com/twisted/twisted/pull/1570
You can send your comments over email or over GitHub
https://github.com/twisted/twisted/pull/1614
I plan to do the final release by the end of Sunday UTC time.
Regards
On Wed, 21 Jul 2021 at 19:07, John Santos john@egh.com wrote:
Hi all,
I just finally got around to installing and testing the new RC with our primary Twisted App. Everything seems to work fine.
I continue to be impressed by what a good job Twisted does with backwards compatibility!
-- John Santos
On 7/20/2021 7:23 PM, Adi Roiban wrote:
On Sun, 18 Jul 2021 at 23:42, Richard van der Hoff <richard@matrix.org mailto:richard@matrix.org> wrote:
On 16/07/2021 20:27, Glyph wrote: > >> One particular problem I came across was the type annotation on >> inlineCallbacks. I've filed >> https://twistedmatrix.com/trac/ticket/10231 <https://twistedmatrix.com/trac/ticket/10231> about it - would >> appreciate thoughts. >> > This definitely looks wrong; there should be a TypeVar inthere. Adi,
> I'd go so far as to say that this should be a release blocker, > although the change should be fairly minimal. > > Richard, could you please make a proper PR for this to get CIkicked
> off and make sure the new annotation doesn't cause any failures? Done, in the form of https://github.com/twisted/twisted/pull/1632 <https://github.com/twisted/twisted/pull/1632>.Hi
Thanks to Thomas and Richard 21.7.0 RC2 was released.
Release notes https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2 https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc2
PyPy page https://pypi.org/project/Twisted/21.7.0rc2/ https://pypi.org/project/Twisted/21.7.0rc2/
Please test and send any issue over email or GitHub Pull request at https://github.com/twisted/twisted/pull/1614 https://github.com/twisted/twisted/pull/1614
If all is ok, I plan to do the final release by the end of Friday or
during the
weekend.
Hi,
The final release is ready for review https://github.com/twisted/twisted/pull/1614
Please take a look and leave your comments over GitHub.
Once the PR is approved I will create the final release.
Cheers
-
Adi Roiban -
Adi Roiban -
Barry Scott -
Glyph -
John Santos -
Melanie Molifie -
Richard van der Hoff