[Twisted-Python] XMLRPC Server: Bug with None response
Message interesting for the following twisted developpers (@see ticket #1132): - oubiwann - jknight - itarmarst Hi, as we have seen in our developpment spikes and at this place: http://twistedmatrix.com/pipermail/twisted-web/2005-September/001903.html there's a bug when Twisted XML-RPC server deals with 'None' method response. The previous message has given a patch (seen at the end of message) for using the 'allow_none' parameter in order to resolve bug. As we are new twisted users and haven't seen any revision for twisted.web.xmlrpc module (since 2 years), we are asking twisted-community the following questions: - is this patch acceptable? - will it be include in next twisted revision? We have seen that a new xmlrpc.py is ready to be committed in the web2 package (see ticket #1132: http://twistedmatrix.com/trac/ticket/1132) but it doesn't seem to include the previous patch. Moreover, what about ticket #914 (uncatched exceptions we have also encountered) ? Regards, Vincent & Yvain
On Wed, 08 Mar 2006 15:43:30 +0000, Yvain Malsot <ymalsot@besancon.parkeon.com> wrote:
Message interesting for the following twisted developpers (@see ticket #1132): - oubiwann - jknight - itarmarst
Hi,
as we have seen in our developpment spikes and at this place: http://twistedmatrix.com/pipermail/twisted-web/2005-September/001903.html there's a bug when Twisted XML-RPC server deals with 'None' method response.
The previous message has given a patch (seen at the end of message) for using the 'allow_none' parameter in order to resolve bug.
As we are new twisted users and haven't seen any revision for twisted.web.xmlrpc module (since 2 years), we are asking twisted-community the following questions: - is this patch acceptable? - will it be include in next twisted revision?
We have seen that a new xmlrpc.py is ready to be committed in the web2 package (see ticket #1132: http://twistedmatrix.com/trac/ticket/1132) but it doesn't seem to include the previous patch.
Problems with the patch: * Doesn't follow the coding standard (allow_none should be allowNone) * Includes no unit tests * Includes no documentation * Isn't in the bug tracker The feature itself and the implementation otherwise seem reasonable to me. Jean-Paul
On Wed, 2006-03-08 at 11:13 -0500, Jean-Paul Calderone wrote:
We have seen that a new xmlrpc.py is ready to be committed in the web2 package (see ticket #1132: http://twistedmatrix.com/trac/ticket/1132) but it doesn't seem to include the previous patch.
Problems with the patch:
* Doesn't follow the coding standard (allow_none should be allowNone) * Includes no unit tests * Includes no documentation * Isn't in the bug tracker
There's actually already a patch in the tracker for None support in twisted.web.xmlrpc: http://twistedmatrix.com/trac/ticket/469 However, it did not have tests, and also made the tests fail when last I applied it.
Itamar Shtull-Trauring wrote:
On Wed, 2006-03-08 at 11:13 -0500, Jean-Paul Calderone wrote:
We have seen that a new xmlrpc.py is ready to be committed in the web2 package (see ticket #1132: http://twistedmatrix.com/trac/ticket/1132) but it doesn't seem to include the previous patch.
Problems with the patch:
* Doesn't follow the coding standard (allow_none should be allowNone) * Includes no unit tests * Includes no documentation * Isn't in the bug tracker
There's actually already a patch in the tracker for None support in twisted.web.xmlrpc: http://twistedmatrix.com/trac/ticket/469
However, it did not have tests, and also made the tests fail when last I applied it.
I've not delved into the code but found the following in: http://twistedmatrix.com/trac/attachment/ticket/469/xmlrpc_allowNone_by_xmlr... Line 297: def __init__(self, url, host, method, allowNone=0, *args): I don't think you can have *args after a 'named' argument. Have you tried: def __init__(self, url, host, method, *args, allowNone=0): - Remi -
participants (4)
-
Itamar Shtull-Trauring -
Jean-Paul Calderone -
Remi Cool -
Yvain Malsot