[Twisted-Python] Add support for Next Protocol Negotiation and Application Layer Protocol Negotiation
Hi, I just want to let you know about this patch which is in work : https://twistedmatrix.com/trac/ticket/7860 I did an initial review but it would help to get more feedback for this new API. Also it depends on a new pyOpenSSL 0.15 version. Do we have a buildslave with this version? What is the process of testing / reviewing this kind of patches? Many thanks! -- Adi Roiban
On 21 Apr 2015, at 23:25, Adi Roiban <adi@roiban.ro> wrote:
Hi,
I just want to let you know about this patch which is in work : https://twistedmatrix.com/trac/ticket/7860
I did an initial review but it would help to get more feedback for this new API.
Also it depends on a new pyOpenSSL 0.15 version. Do we have a buildslave with this version? What is the process of testing / reviewing this kind of patches?
Many thanks! -- Adi Roiban
Oooh, exciting. I do not think we have a buildslave with this version. My Debian 7 2.7/3.3/3.4/3.5a4 builders, when I get them up, will have 0.15, with an OpenSSL supporting NPN but not ALPN (1.0.2 or greater for ALPN, Debian 7 has 1.0.1.). - hawkie
On 21/04/15 16:25, Adi Roiban wrote:
Hi,
I just want to let you know about this patch which is in work : https://twistedmatrix.com/trac/ticket/7860
Nice.
I did an initial review but it would help to get more feedback for this new API.
I would very, very much like to see something along the lines of a factory-of-factories which handles creating the protocol instances on connections automatically. Straw-man API: class NegoFactory(tls.NegoFactory): nextProtocols = ('h2', 'http/1.1') def buildProtocol(self, addr, nextproto): if nextproto=='h2': return H2Proto() elif nextproto=='http/1.1': return HttpProto() else: raise NotImplemented() f = NegoFactory() listenSSL(port, f) The basic protocol level support is great, but it'll be much easier to use if there's a Twisted-like API on top of it. But don't block the main ticket - open another one up maybe?
participants (3)
-
Adi Roiban -
HawkOwl -
Phil Mayers