twisted.passport.challenge.__doc__ says:

This is a method rather than a module-level function because it is anticipated that we will want to change this to store salted passwords.

but the update moved challenge so it *is* a module-level function. Should that docstring not have been cutnpasted and still be on passport.Identity.challenge, or did the reasoning change in which case the docstring needs updating? ----------

Update of /cvs/Twisted/doc/examples

Now pbsimple.py has the class named "Echoer" and pbecho.py has the class named "SimpleService". Is supposed to be that way? Seems backwards. ----------

Update of /cvs/Twisted/twisted/python

Modified Files: defer.py

diff -b -u -d -r1.7 -r1.8 --- defer.py 2001/10/07 12:25:15 1.7 +++ defer.py 2001/10/07 12:54:46 1.8 class Deferred: # [...] def runCallbacks(self, result, isError): """Run all callbacks and/or errors that have been added to this Deferred.

Each callback will have its result passed as the first argument to the next; this way, the callbacks act as a 'processing chain'. If this deferred has not been armed yet, nothing will happen. """ self.called = isError + 1 if self.armed: for item in self.callbacks: callback, args, kw = item[isError] args = args or ()

@@ -72,12 +73,15 @@ kw = kw or {} try: # print callback, result, args, kw + # print 'defres:',callback,result result = apply(callback, (result,)+args, kw) + if type(result) != types.StringType: + isError = 0 # # I don't get it -- what's this typecheck for? Is there documentation # on the meaning of return values for Deferreds that I'm missing? # except: io = StringIO() traceback.print_exc(file=io) gv = io.getvalue() - print gv + print 'Deferred Error', gv result = gv isError = 1 else: [...]

-- Kevin Turner <acapnotic@twistedmatrix.com> | OpenPGP encryption welcome The moon is waning gibbous, 73.4% illuminated, 19.9 days old.