[Twisted-Python] twisted/conch/_common violates standard. also annoying.
I've already talked to z3p in private about this, but this has done no good. _common is a binding to some more parts of the gmp library for Python, which is included in conch for speed-ups. I would like it to be moved to a different project for Python/gmp bindings (upstream Python, gmpy.sf.net or a new sf-based or tm.com-based project). If it will be so moved, I'll do the Debian packaging and upload, and have the conch packages recommend it. As is, I've currently disabled it in the Debian build, because integrating it is just too hairy. The coding standard specifically advises against such behaviour, for good reasons. Thanks, Moshe
On 2 Dec 2002, Moshe Zadka <twisted@moshez.org> wrote:
to be moved to a different project for Python/gmp bindings (upstream Python, gmpy.sf.net or a new sf-based or tm.com-based project).
z3p complained about gmpy not compiling out of the box. The following patch makes it compile: moshez@pyramid:~/sources/gmpy$ diff -u gmpy.c gmpy.c.fixed --- gmpy.c Fri Jan 26 06:32:51 2001 +++ gmpy.c.fixed Mon Dec 2 05:35:27 2002 @@ -5050,7 +5050,7 @@ } else { PympzObject *resob = Pympz_new(); if(resob) { - mpz_set(resob->z, randstate->seed); + mpz_set(resob->z, randstate->_mp_seed); result = (PyObject*)resob; } }
On Mon, Dec 02, 2002 at 11:34:31AM -0000, Moshe Zadka wrote:
YES -- Christopher Armstrong << radix@twistedmatrix.com >> http://twistedmatrix.com/users/radix.twistd/
On 2 Dec 2002, Moshe Zadka <twisted@moshez.org> wrote:
to be moved to a different project for Python/gmp bindings (upstream Python, gmpy.sf.net or a new sf-based or tm.com-based project).
z3p complained about gmpy not compiling out of the box. The following patch makes it compile: moshez@pyramid:~/sources/gmpy$ diff -u gmpy.c gmpy.c.fixed --- gmpy.c Fri Jan 26 06:32:51 2001 +++ gmpy.c.fixed Mon Dec 2 05:35:27 2002 @@ -5050,7 +5050,7 @@ } else { PympzObject *resob = Pympz_new(); if(resob) { - mpz_set(resob->z, randstate->seed); + mpz_set(resob->z, randstate->_mp_seed); result = (PyObject*)resob; } }
On Mon, Dec 02, 2002 at 11:34:31AM -0000, Moshe Zadka wrote:
YES -- Christopher Armstrong << radix@twistedmatrix.com >> http://twistedmatrix.com/users/radix.twistd/
participants (2)
-
Christopher Armstrong -
Moshe Zadka