On 2012/08/19, at 17:28, Glyph wrote:

On Aug 19, 2012, at 1:35 PM, Matthew Pounsett <matt@conundrum.com> wrote:

...

I've been reading the cred docs, and think I may have spotted a typo. Near the end of <http://twistedmatrix.com/documents/current/core/howto/cred.html>, in the code sample describing creating a cred plugin's factory, there is this method:

# This will be called once per command-line. def generateChecker(self, argstring=""): argdict = dict((x.split('=') for x in argstring.split(':'))) return SpecialChecker(**dict)

I think that return should actually be for **argdict, yes?

Quite so. Want to file a ticket?

Will do. Thanks, I just wanted to make sure what I was thinking made sense before I do that.

On 2012/08/19, at 17:28, Glyph wrote:

On Aug 19, 2012, at 1:35 PM, Matthew Pounsett <matt@conundrum.com> wrote:

...

I've been reading the cred docs, and think I may have spotted a typo. Near the end of <http://twistedmatrix.com/documents/current/core/howto/cred.html>, in the code sample describing creating a cred plugin's factory, there is this method:

# This will be called once per command-line. def generateChecker(self, argstring=""): argdict = dict((x.split('=') for x in argstring.split(':'))) return SpecialChecker(**dict)

I think that return should actually be for **argdict, yes?

Quite so. Want to file a ticket?

Will do. Thanks, I just wanted to make sure what I was thinking made sense before I do that.