[Twisted-Python] Re: [Twisted-commits] make log.err return the thing you pass to it
On Sat, Nov 08, 2003 at 04:51:25AM -0700, radix CVS wrote:
Modified files: Twisted/twisted/python/log.py 1.52 1.53
Log message: make log.err return the thing you pass to it
Isn't this a fairly significant change to the API? Now doing deferred.addErrback(log.err) will log the error, and then log it again when the deferred is garbage-collected... I guess it won't actually break anything, just add some confusion to log files, but what's the new idiom for d.addErrback(log.err) # log and swallow any errors that happened going to be? -Andrew.
How does twisted shut things down and recover resources when implementing a reverse-proxy. If one or another of the endpoints dies, I would expect there to be some shutdown code to close open sockets, etc. but I don't seem to be able to find it. Can someone assist?
And one more thing. How are timeouts on connections managed? On Sat, 8 Nov 2003, Dennis Allison wrote:
How does twisted shut things down and recover resources when implementing a reverse-proxy. If one or another of the endpoints dies, I would expect there to be some shutdown code to close open sockets, etc. but I don't seem to be able to find it. Can someone assist?
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-- Dennis Allison * Computer Systems Laboratory * Gates 227 * Stanford University * Stanford CA 94305 * (650) 723-9213 * (650) 723-0033 fax * allison@shasta.stanford.edu * allison@sumeru.stanford.edu
I guess somebody else beat me to telling radix to revert :). Also, On Nov 8, 2003, at 9:12 AM, Andrew Bennetts wrote:
I guess it won't actually break anything
Actually, it will break things, as exarkun pointed out on IRC: foo.addErrback(log.err).addCallback(cleanup) will no longer call 'cleanup'. Totally unnecessary breakage.
participants (3)
-
Andrew Bennetts -
Dennis Allison -
Glyph Lefkowitz