[Twisted-Python] towncrier review policies and etiquette (and maybe releases too)
![](https://secure.gravatar.com/avatar/d3dd3ba5cbd197a5927366c6c9a5003d.jpg?s=120&d=mm&r=g)
Where does towncrier stand on review policies and etiquette? I generally don't like to just jump into new projects and start reviewing and merging but I don't see other activity on that front nor do I see any guidance on how it should be done. If I know how to proceed properly then I might dedicate some review time to it. Cheers, -kyle
![](https://secure.gravatar.com/avatar/bcb6ef473ff1644fddee1b4e7c730b01.jpg?s=120&d=mm&r=g)
I think that it's fine to fall back to the twisted/twisted policies[1] for any project in the Twisted GitHub organization. The workflow won't apply directly --- no Trac, etc. --- but the core "someone must review all changes" and "test all the things" principles are relevant. That's how I treat Treq. ---Tom [1]: https://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs On Wed, Oct 21, 2020, at 12:11 PM, Kyle Altendorf wrote:
![](https://secure.gravatar.com/avatar/bcb6ef473ff1644fddee1b4e7c730b01.jpg?s=120&d=mm&r=g)
I think that it's fine to fall back to the twisted/twisted policies[1] for any project in the Twisted GitHub organization. The workflow won't apply directly --- no Trac, etc. --- but the core "someone must review all changes" and "test all the things" principles are relevant. That's how I treat Treq. ---Tom [1]: https://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs On Wed, Oct 21, 2020, at 12:11 PM, Kyle Altendorf wrote:
participants (3)
-
Glyph
-
Kyle Altendorf
-
Tom Most