[Twisted-Python] towncrier review policies and etiquette (and maybe releases too)
Where does towncrier stand on review policies and etiquette? I generally don't like to just jump into new projects and start reviewing and merging but I don't see other activity on that front nor do I see any guidance on how it should be done. If I know how to proceed properly then I might dedicate some review time to it. Cheers, -kyle
I think that it's fine to fall back to the twisted/twisted policies[1] for any project in the Twisted GitHub organization. The workflow won't apply directly --- no Trac, etc. --- but the core "someone must review all changes" and "test all the things" principles are relevant. That's how I treat Treq. ---Tom [1]: https://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs On Wed, Oct 21, 2020, at 12:11 PM, Kyle Altendorf wrote:
Where does towncrier stand on review policies and etiquette? I generally don't like to just jump into new projects and start reviewing and merging but I don't see other activity on that front nor do I see any guidance on how it should be done. If I know how to proceed properly then I might dedicate some review time to it.
Cheers, -kyle
I'd love to update these policy documents to have something explicitly org-wide, but until somebody has the time to go through and do that properly, this is generally a good assumption to have.
On Oct 21, 2020, at 1:59 PM, Tom Most <twm@freecog.net> wrote:
I think that it's fine to fall back to the twisted/twisted policies[1] for any project in the Twisted GitHub organization. The workflow won't apply directly --- no Trac, etc. --- but the core "someone must review all changes" and "test all the things" principles are relevant. That's how I treat Treq.
---Tom
[1]: https://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs
On Wed, Oct 21, 2020, at 12:11 PM, Kyle Altendorf wrote:
Where does towncrier stand on review policies and etiquette? I generally don't like to just jump into new projects and start reviewing and merging but I don't see other activity on that front nor do I see any guidance on how it should be done. If I know how to proceed properly then I might dedicate some review time to it.
Cheers, -kyle
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
participants (3)
-
Glyph -
Kyle Altendorf -
Tom Most