On Jul 4, 2011, at 9:48 PM, Diane Trout wrote:

...

Almost - I should have mentioned <http://twistedmatrix.com/trac/wiki/TwistedDevelopment> and <http://twistedmatrix.com/trac/wiki/ReviewProcess> first.

When you put that branch on Launchpad, you'll need to put #4799 into review as well, as per that process; just link to the branch. Also, make it clear that you've volunteered for this work somewhere public, ideally in a ticket comment.

Thanks again! Please don't hesitate to get in touch if you need any further guidance.

Ok I have linked to my branch in http://twistedmatrix.com/trac/ticket/4799

Does that look right? is the next step to put "review" into 4799's keywords field?

The next step is actually to make a backported patch specifically for <http://tm.tl/4799>, and get that merged into a release branch. The idea with the release ticket is that it's for the release notes and final QA; all the actual code should be complete in individual feature tickets first. I'm sorry - now I'm noticing that the workflow on the linked tickets (for example <http://tm.tl/4786>) is actually wrong for a maintenance release, as there's no cloned bug to indicate the backport. If I recall correctly, /branches/releases/release-10.2.0-4651-2 is the branch to merge things into for a 10.2.x maintenance release. At this point it would probably be good to get on the mailing list <http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python> and discuss these issues more publicly; someone else with more experience with the release toolchain can provide you more specific advice, and you'll get faster responses than from me personally. I'm Cc:ing this message to that list so that there will be some context when the discussion starts. I was going to recommend the IRC channel too, but I am told you've already been there; I hope I'll run into you there :).

Also I don't know how to get the code changes out of launchpad and into your svn repository.

A committer will do that, based on your branch. You may have to use our all-branches mirror to continue work, as Launchpad only mirrors trunk. Or, you may become an committer; we normally ask that people fix a few smaller bugs first, but given that you're volunteering to manage a release we may expedite that process :).

Diane

Once again I _really_ appreciate your time here. As you can probably tell, we rarely have the contributor bandwidth to do maintenance releases and so we're somewhat rusty at it. We like to provide a smooth upgrade process for our users though, so when we manage to get this pushed through it will be a big benefit to our XMPP users. Thanks, -glyph