Re: [Twisted-Python] Buildbot upgrade to latest eight branch
On 25 June 2016 at 16:53, Tom Prince tom.prince@ualberta.net wrote:
I'll try to review this this weekend.
I have merged the GitHub commit status as I think that it was working OK.
I have now deployed the GitHub Hooks build trigger changes.
Build are automatically triggered for all pushes in all branches. There is a delay of 5 seconds so that multiple builds pushed in the same time will only trigger a single build for the last commit.
See this PR for details and if you want to review it :)
https://github.com/twisted-infra/braid/pull/208
With this change, Buildbot should have a closer behavior to Travis-CI. That is, it will automatically start the builders and will report the build results in GitHub PR.
Happy hacking :)
On 2 Jul 2016, at 23:42, Adi Roiban adi@roiban.ro wrote:
With this change, Buildbot should have a closer behavior to Travis-CI. That is, it will automatically start the builders and will report the build results in GitHub PR.
I spotted this in action today before I’d read this list post, so I just want to say: thanks so much for this Adi! This is one of those little changes that makes life a great deal nicer for me as a reviewer *and* contributor: not needing to do the dance with forcing the buildbots to run is really excellent.
Cory
On 4 July 2016 at 11:06, Cory Benfield cory@lukasa.co.uk wrote:
On 2 Jul 2016, at 23:42, Adi Roiban adi@roiban.ro wrote:
With this change, Buildbot should have a closer behavior to Travis-CI.
That is, it will automatically start the builders and will report the build results in GitHub PR.
I spotted this in action today before I’d read this list post, so I just want to say: thanks so much for this Adi! This is one of those little changes that makes life a great deal nicer for me as a reviewer *and* contributor: not needing to do the dance with forcing the buildbots to run is really excellent.
With this change you no longer have to create duplicate PR for "imported" branches . Just create the branch and Travis and Buildbot will automatically do their job and you can merge the "imported" branch without a PR.
"Imported" branch is a branch hosted in the Twisted main repo but which contains changes merged from a forked repo.
participants (2)
-
Adi Roiban -
Cory Benfield