[Twisted-Python] Minor bug in FTPFactory
Hi folks, I found a bug at FTPFactory class. Here is the link to the code: http://twistedmatrix.com/trac/browser/tags/releases/twisted-8.1.0/twisted/pr... The argument userAnonymous is useless as the instance variable is not being set by the value received by this argument during object construction. I don't know if here is the place for such discussion. Is there another better place for that? Also, am I supposed to send a patch fixing that here? I don't know if this mailing list accept attachments. Kind Regards, -- Adriano Monteiro Marques http://adriano-marques.blogspot.com http://umit.sourceforge.net py.adriano@gmail.com "Don't stay in bed, unless you can make money in bed." - George Burns
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Adriano Marques wrote:
Hi, the correct thing to do is to write a unittest for it (in [1]) and a patch and attach it to a ticket on the Twisted website. 1. http://twistedmatrix.com/trac/browser/tags/releases/twisted-8.1.0/twisted/te... Kind regards, Tarjei
Kind Regards,
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIlGh0YVRKCnSvzfIRAuAWAJ9BePRiBHmW0JuVXXaAK7GEKOe0hgCfW/+1 ysbBQXD17R44yQLAbIJPhkI= =BhiA -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Adriano Marques wrote:
Hi, the correct thing to do is to write a unittest for it (in [1]) and a patch and attach it to a ticket on the Twisted website. 1. http://twistedmatrix.com/trac/browser/tags/releases/twisted-8.1.0/twisted/te... Kind regards, Tarjei
Kind Regards,
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIlGh0YVRKCnSvzfIRAuAWAJ9BePRiBHmW0JuVXXaAK7GEKOe0hgCfW/+1 ysbBQXD17R44yQLAbIJPhkI= =BhiA -----END PGP SIGNATURE-----
participants (2)
-
Adriano Marques -
tarjei