[Twisted-Python] Another patch for twisted-im
This one's dead simple, and shouldn't cause any discussion. :) -- ___________ ____________________________ | Screwtape | Reply-To: munged on Usenet |________ ______ ____ __ _ _ _ | | I don't usually .sig people in newsgroups. -- Charles Lieberman |
On Fri, Nov 08, 2002 at 05:47:50PM +1100, screwtape@froup.com scrawled:
This one's dead simple, and shouldn't cause any discussion. :)
Yes, it should. :P
diff -u -r1.20 ircsupport.py --- ircsupport.py 2 Nov 2002 16:53:56 -0000 1.20 +++ ircsupport.py 8 Nov 2002 07:06:18 -0000 @@ -95,7 +95,7 @@ if self.account.password: self.sendLine("PASS :%s" % self.account.password) self.setNick(self.account.nickname) - self.sendLine("USER %s foo bar :GTK-IM user"%self.nickname) + self.sendLine("USER %s foo bar :Twisted-IM user"%self.nickname)
IMHO "user" should be configurable, too; that's the username that shows up. -- Daniel Stone <daniel@raging.dropbear.id.au> <dstone@kde.org> Developer - http://kopete.kde.org, http://www.kde.org
On Fri, Nov 08, 2002 at 06:19:21PM +1100, Daniel Stone wrote:
On Fri, Nov 08, 2002 at 05:47:50PM +1100, screwtape@froup.com scrawled:
This one's dead simple, and shouldn't cause any discussion. :)
Yes, it should. :P
diff -u -r1.20 ircsupport.py --- ircsupport.py 2 Nov 2002 16:53:56 -0000 1.20 +++ ircsupport.py 8 Nov 2002 07:06:18 -0000 @@ -95,7 +95,7 @@ if self.account.password: self.sendLine("PASS :%s" % self.account.password) self.setNick(self.account.nickname) - self.sendLine("USER %s foo bar :GTK-IM user"%self.nickname) + self.sendLine("USER %s foo bar :Twisted-IM user"%self.nickname)
IMHO "user" should be configurable, too; that's the username that shows up.
Oh, crud. I cvs diff'd from Twisted/twisted/im, I assumed magical CVS would fix up all the pathnames. Anyway, the above happens inside twisted.im's IRC abstraction. I don't think there's other protocols that let you define your real name every time you connect (Jabber, for instance, keeps it on the server), so exposing an API to deal with IRC's nonconformity would seem to be a Bad Thing. In theory, you could just make it the same as the nickname, but (a) that's pretty pointless, and (b), we lose a chance to advertise Twisted. :) Also, glyph made it a hard-coded string when he first wrote it, so he probably thinks that's the Way To Go. :) At any rate, the same file is used by both the java and GTK front-ends, so it shouldn't say GTK-IM. -- ___________ ____________________________ | Screwtape | Reply-To: munged on Usenet |________ ______ ____ __ _ _ _ | | "What do you mean, `naked'?" |
On Fri, Nov 08, 2002 at 08:46:07PM +1100, screwtape@froup.com scrawled:
On Fri, Nov 08, 2002 at 06:19:21PM +1100, Daniel Stone wrote:
On Fri, Nov 08, 2002 at 05:47:50PM +1100, screwtape@froup.com scrawled:
+ self.sendLine("USER %s foo bar :Twisted-IM user"%self.nickname) ^
IMHO "user" should be configurable, too; that's the username that shows up.
Oh, crud. I cvs diff'd from Twisted/twisted/im, I assumed magical CVS would fix up all the pathnames.
Anyway, the above happens inside twisted.im's IRC abstraction. I don't think there's other protocols that let you define your real name every time you connect (Jabber, for instance, keeps it on the server), so exposing an API to deal with IRC's nonconformity would seem to be a Bad Thing.
In theory, you could just make it the same as the nickname, but (a) that's pretty pointless, and (b), we lose a chance to advertise Twisted. :)
Also, glyph made it a hard-coded string when he first wrote it, so he probably thinks that's the Way To Go. :)
At any rate, the same file is used by both the java and GTK front-ends, so it shouldn't say GTK-IM.
Sorry, I'm stupid. I didn't see the colon, and thought you were just using "user" for the username. Forgive me. -- Daniel Stone <daniel@raging.dropbear.id.au> <dstone@kde.org> Developer - http://kopete.kde.org, http://www.kde.org
On Fri, Nov 08, 2002 at 10:57:43AM -0000, Moshe Zadka wrote:
On Fri, 8 Nov 2002 20:46:07 +1100, screwtape@froup.com wrote:
Oh, crud. I cvs diff'd from Twisted/twisted/im, I assumed magical CVS would fix up all the pathnames.
In general, I prefer to do local diffs against a clean checkout.
Why? Is there an appreciable difference? Screwtape, ...who still thinks cvs is a shiny, wonderful thing. -- ___________ ____________________________ | Screwtape | Reply-To: munged on Usenet |________ ______ ____ __ _ _ _ | | "Ecce Macdonaldus Senex, qui fundum habet. E-I-E-I-O." -- Sarah Boynton |
On Fri, 8 Nov 2002, screwtape@froup.com wrote:
Why? Is there an appreciable difference?
Local diffs are more patch friendly. IIRC there was a script floating around that converts to make it more patch friendly, but until the Twisted developers officially locate it, I personally prefer local diffs.
participants (3)
-
Daniel Stone -
Moshe Zadka -
screwtape＠froup.com