[Twisted-Python] Win32 fix for twisted/internet/tcp.py

Hi there, I just downloaded the twisted words package, and tried the ircLogBot.py sample. It came up with an error on my Win32 box, but worked fine on my linux box. The error on win32 was due to the following line 512 in twisted/internet/tcp.py: r, w, e = select.select([], [], [self.fileno()], 0.0) The select module on Win32 doesn't accept empty read/write handles, so it generated an 'invalid argument' exception. I changed line 512 to the following, and the sample now works on win32. r, w, e = select.select([self.fileno()], [self.fileno()], [self.fileno()], 0.0) P.S: I used Twisted 2.4.0 and twisted words 0.3.0 Hope you find my report useful, even if win32 bugs aren't a priority ;) Cheers, Joe

On Sat, 24 Jun 2006 01:12:57 +1000, Joe Cotroneo <joe@neosource.com.au> wrote:
What version of Python and Windows? I wouldn't expect any Twisted application to run on a machine where that line unconditionally raises an exception, but clearly some does. Does anything else work for you? Jean-Paul

Hi Joe, On Sat, 24 Jun 2006 01:12:57 +1000, Joe Cotroneo <joe@neosource.com.au> wrote:
I don't want people to get the wrong impression: Win32 *IS* a fully supported platform. Our support could be better than it is, but fixing win32 bugs in the existing code is just as much of a priority as any other platform. Commits that breaks tests on win32 are reverted almost immediately. The only issue is that there are simply fewer developers who have the desire, expertise, or dev evironments to work on Windows.
Cheers,
Joe
-- Eric Mangold - Twisted/Win32 Maintainer http://twistedmatrix.com/trac/wiki/Windows

On Sat, 24 Jun 2006 01:12:57 +1000, Joe Cotroneo <joe@neosource.com.au> wrote:
What version of Python and Windows? I wouldn't expect any Twisted application to run on a machine where that line unconditionally raises an exception, but clearly some does. Does anything else work for you? Jean-Paul

Hi Joe, On Sat, 24 Jun 2006 01:12:57 +1000, Joe Cotroneo <joe@neosource.com.au> wrote:
I don't want people to get the wrong impression: Win32 *IS* a fully supported platform. Our support could be better than it is, but fixing win32 bugs in the existing code is just as much of a priority as any other platform. Commits that breaks tests on win32 are reverted almost immediately. The only issue is that there are simply fewer developers who have the desire, expertise, or dev evironments to work on Windows.
Cheers,
Joe
-- Eric Mangold - Twisted/Win32 Maintainer http://twistedmatrix.com/trac/wiki/Windows
participants (4)
-
Eric Mangold
-
Itamar Shtull-Trauring
-
Jean-Paul Calderone
-
Joe Cotroneo