[Twisted-Python] Who's using Gtk reactor?
Greetings, As part of the work I've been doing to fix a bug in epoll reactor's handling of "unclean" tcp disconnection (the case which gives ConnectionLost instead of ConnectionDone), I've noticed that gtk reactor also doesn't handle this case correctly. Anyone who has looked at gtkreactor.py probably knows this (there's a big comment in _readAndWrite, so whoever wrote it in the first place realized what they were doing). Before I fixed epoll reactor, I added a test for this case. Gtk reactor won't be able to pass this test, since it doesn't provide the correct functionality. I'm not going to fix gtk reactor, since glib2 or gtk2 reactor is really what people should be using these days. However, if someone else is interested in fixing gtk reactor, the fix would be happily accepted (the hard part is done, since the unit test is written already ;). If no one is interested in fixing it, though, then I think this is a good time to start thinking about deprecating gtk reactor and eventually removing it. Anyone have any thoughts on this? Jean-Paul
On Sun, 2007-09-16 at 11:25 -0400, Jean-Paul Calderone wrote:
Greetings,
As part of the work I've been doing to fix a bug in epoll reactor's handling of "unclean" tcp disconnection (the case which gives ConnectionLost instead of ConnectionDone), I've noticed that gtk reactor also doesn't handle this case correctly.
Just to clarify, JP is talking about the reactor for the long unmaintained Gtk 1.x library, last released in 2001. Modern Gtk and Gnome programs use Gtk 2.x for which Twisted provides the gtk2 and glib2 reactors.
On Mon, 17 Sep 2007 09:23:22 -0400, Itamar Shtull-Trauring <itamar@itamarst.org> wrote:
On Sun, 2007-09-16 at 11:25 -0400, Jean-Paul Calderone wrote:
Greetings,
As part of the work I've been doing to fix a bug in epoll reactor's handling of "unclean" tcp disconnection (the case which gives ConnectionLost instead of ConnectionDone), I've noticed that gtk reactor also doesn't handle this case correctly.
Just to clarify, JP is talking about the reactor for the long unmaintained Gtk 1.x library, last released in 2001. Modern Gtk and Gnome programs use Gtk 2.x for which Twisted provides the gtk2 and glib2 reactors.
Thanks for that clarification. Since there's been no response thus far, I've created a ticket to deprecate the reactor - #2833. This will probably happen before Twisted 2.6. Any other discussion should probably be directed at that ticket. Jean-Paul
participants (2)
-
Itamar Shtull-Trauring
-
Jean-Paul Calderone