On 17 September 2013 16:34, Phil Mayers wrote:

On 17/09/13 15:29, Richard Wall wrote:

...

PS. I'd love to merge https://tm.tl/5675 before the conference, so if you're familiar with the DNS RFCs, I'd really appreciate a code review. I'm rwall on #twisted-dev and #twisted if you want to discuss it

Deep breath... I'll give this a go.

Thanks Phil, I'd seen your previous work in this area and was hoping you'd reply. :) You might be interested to read the reviews of https://twistedmatrix.com/trac/ticket/5675 where we introduced support for parsing of OPT pseudo records. Meanwhile, I'll see if I can help exarkun with the code review checklist. Thanks again and I look forward to your feedback. -RichardW.