Thanks for the feedback! I can put up a PR to add those changes. Cheers, Maggie ________________________________ From: Brett Cannon <brett@python.org> Sent: Thursday, August 13, 2020 3:34 PM To: Guido van Rossum <guido@python.org> Cc: typing-sig@python.org <typing-sig@python.org>; Philippe Prados <philippe.prados@gmail.com>; Maggie Moss <maggiemoss@fb.com>; Chris Angelico <rosuav@gmail.com> Subject: Re: [Typing-sig] Re: PEP 604 ready for acceptance (Allow writing union types as X | Y) Not that it matters at this point, but LGTM! Just two quick things to maybe change in the PEP: " this operator introduce a dependency" -> "introduces" " As breaking the backport" reads awkwardly as the other bullet points don't seem to assume reading "Con" before the sentence. On Thu, Aug 13, 2020 at 3:00 PM Guido van Rossum <guido@python.org<mailto:guido@python.org>> wrote: Done! On Wed, Aug 12, 2020 at 1:40 PM Guido van Rossum <guido@python.org<mailto:guido@python.org>> wrote: I'm ready to pronounce PEP 604 as accepted: https://www.python.org/dev/peps/pep-0604/<https://urldefense.proofpoint.com/v2/url?u=https-3A__www.python.org_dev_peps_pep-2D0604_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=f28uZNOWonDFk7FJQDoV1HxAt9325GELs0nSw_fZ-QQ&m=IXJjMQdhtEGj2Y89YSxuUlS3ahvJaWr_BEBmNB8HkOY&s=3q-WV3_YkWjxATXhL3TITEOz-D4whutwg6xM34p5hYk&e=> With the help of Maggie Moss the PEP has received some updates clarifying the specification; Maggie's implementation is also well under way. Unless there are objections here within the next 24 hours I will accept the PEP, and the feature will launch in Python 3.10. Thanks Philippe Prados for bringing this to PEP level and thanks to Maggie for her implementation work. -- --Guido van Rossum (python.org/~guido<https://urldefense.proofpoint.com/v2/url?u=http-3A__python.org_-7Eguido&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=f28uZNOWonDFk7FJQDoV1HxAt9325GELs0nSw_fZ-QQ&m=IXJjMQdhtEGj2Y89YSxuUlS3ahvJaWr_BEBmNB8HkOY&s=u1vPTthwelCTrNwFZxYzF7-54OPbzyLItuxu90tLqKM&e=>) Pronouns: he/him (why is my pronoun here?)<https://urldefense.proofpoint.com/v2/url?u=http-3A__feministing.com_2015_02_03_how-2Dusing-2Dthey-2Das-2Da-2Dsingular-2Dpronoun-2Dcan-2Dchange-2Dthe-2Dworld_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=f28uZNOWonDFk7FJQDoV1HxAt9325GELs0nSw_fZ-QQ&m=IXJjMQdhtEGj2Y89YSxuUlS3ahvJaWr_BEBmNB8HkOY&s=3gpV_jPbIqL7_5Ss-NmIEZ0hQrwy8He7hBwotwWzzdY&e=> -- --Guido van Rossum (python.org/~guido<https://urldefense.proofpoint.com/v2/url?u=http-3A__python.org_-7Eguido&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=f28uZNOWonDFk7FJQDoV1HxAt9325GELs0nSw_fZ-QQ&m=IXJjMQdhtEGj2Y89YSxuUlS3ahvJaWr_BEBmNB8HkOY&s=u1vPTthwelCTrNwFZxYzF7-54OPbzyLItuxu90tLqKM&e=>) Pronouns: he/him (why is my pronoun here?)<https://urldefense.proofpoint.com/v2/url?u=http-3A__feministing.com_2015_02_03_how-2Dusing-2Dthey-2Das-2Da-2Dsingular-2Dpronoun-2Dcan-2Dchange-2Dthe-2Dworld_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=f28uZNOWonDFk7FJQDoV1HxAt9325GELs0nSw_fZ-QQ&m=IXJjMQdhtEGj2Y89YSxuUlS3ahvJaWr_BEBmNB8HkOY&s=3gpV_jPbIqL7_5Ss-NmIEZ0hQrwy8He7hBwotwWzzdY&e=> _______________________________________________ Typing-sig mailing list -- typing-sig@python.org<mailto:typing-sig@python.org> To unsubscribe send an email to typing-sig-leave@python.org<mailto:typing-sig-leave@python.org> https://mail.python.org/mailman3/lists/typing-sig.python.org/<https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.python.org_mailman3_lists_typing-2Dsig.python.org_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=f28uZNOWonDFk7FJQDoV1HxAt9325GELs0nSw_fZ-QQ&m=IXJjMQdhtEGj2Y89YSxuUlS3ahvJaWr_BEBmNB8HkOY&s=--_VK7CRTIjgO4smHmKjgGVMTJ0GIeZmt7qrhiV2nTU&e=> Member address: brett@python.org<mailto:brett@python.org>