Yes, this is ready to bring before the SC. On Tue, Oct 22, 2019 at 9:35 AM Ivan Levkivskyi <levkivskyi@gmail.com> wrote:
The mypy problem is just an implementation bug that should be fixed.
Otherwise, I think it is fine to move towards pronouncement. If the authors agree, IIUC the next step for them is to request Steering Council for a BDFL-Delegate, and then post the current PEP text for a review by the delegate.
Guido, is this right?
-- Ivan
On Wed, 16 Oct 2019 at 22:52, Jakub Stasiak <jakub@stasiak.at> wrote:
Let me revive the thread.
As a way to verify the design and the implementation I added Annotated-based markers to Injector (I’ve done it quickly before, now I fully tested it and did it right). https://github.com/alecthomas/injector/commit/d50e581734d6673ab0a2d9de7ccf09... if anyone’s interested. I want to release it soon.
It was rather trivial, with the exception of testing if an object is an instance of Annotated – but once get_origin works with Annotated this won’t be an issue.
I wanted to test mypy integration and I found an issue with aliasing I think, reported here: https://github.com/python/mypy/issues/7729
All in all the typing_extensions implementation seems to be working nicely and this PEP satisfies my needs so far.
Best, Jakub
-- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-change-the-world/>