
On 2/2/22 12:29 PM, S Pradeep Kumar wrote:
On Tue, Feb 1, 2022 at 10:50 PM David Foster <davidfstr@gmail.com Nit: Since this PEP refers to another PEP within the same Python release (i.e. PEP 673), it should probably add the header field "Requires: 673".
Hmm... this PEP doesn't really depend on that PEP. I can just remove the dependency instead of adding a misleading "Requires" heading.
Based on your original PEP wording I was wondering if whether the "LiteralString" and "Self" types in the "typing" module would have a common private base class (or other kind of more-direct dependency). In that case I'd still recommend a "Requires: 673" heading. If instead the LiteralString implementation is more *inspired by* the implementation of the Self type, I agree that omitting the "Requires: 673" heading would be fine. I'm probably splitting hairs here in any case... Regardless, I think it's useful context that `We propose an implementation for typing.LiteralString similar to that for typing.Self from PEP 673.` - or similar wording - so I'd suggest keeping that in the PEP. -- David Foster | Seattle, WA, USA Contributor to TypedDict support for mypy