Hello,
As an initial implementation that will be improved in the future, the
specification in PEP 681 is fine. Feel free to add the decorator to
Python 3.11 at your convenience.
Thanks Petr, that's great to hear!
However, the PEP includes several worrying recommendations like:
- we recommend that the maintainers of attrs move away from the legacy
semantics and adopt auto_attribs behaviors by default.
- We chose not to support this feature and recommend that attrs users
avoid converters.
- Attrs users should use the dataclass-standard eq and order parameter
names instead.
These are probably meant as recommendations from typing-sig, but an
accepted PEP represents consensus of the entire Python community. A
typing PEP is not an appropriate place to make recommendations like
this, especially without reaching out to the maintainer of attrs.
As far as I know,the attrs and pydantic libraries are using the
reference implementation, but their authors weren't consulted on the PEP
itself.
Could you either change the wording (e.g. say that the unsupported
features need bespoke type-checker functionality for proper type
checking), or work with attrs to make the same recommendations in its
documentation?
Agree that these recommendations sound overly normative. I think we should remove the recommendations and simply spell out the features that won't work with dataclass_transform(). It's up to users' own judgment what they do with that information. Erik, could you propose a change to the PEP text?
Happy typing,
— Petr, on behalf of the Steering Council
_______________________________________________
Typing-sig mailing list -- typing-sig@python.org
To unsubscribe send an email to typing-sig-leave@python.org
https://mail.python.org/mailman3/lists/typing-sig.python.org/
Member address: jelle.zijlstra@gmail.com