Madicken merged the PR, so now these commands should work; it needed a bit of adjustment, but we now have:
/help /format /rebase /isort /black
You can see some of our attempts and experiments here:
On Wed, Jul 29, 2020 at 11:21 AM Matthew Turk firstname.lastname@example.org wrote:
I have transferred the repository! Hooray!
On Wed, Jul 29, 2020 at 10:13 AM Corentin Cadiou email@example.com wrote:
That sounds like a really good thing to have. It will probably lower the contribution barrier to what it was before YTEP0037, with the extra benefit of a cleaner code!
29 Jul 2020 15:57:13 Britton Smith firstname.lastname@example.org:
I think this sounds like a great idea. I like the idea of not having to ask contributors to do a lot of PR reformatting on their own. +1 to all of it.
On Mon, Jul 27, 2020 at 10:15 PM Matthew Turk email@example.com wrote:
I got a couple questions off-list about what this means -- basically, with YTEP 37 we've added some restrictions to what we accept, particularly in how we format code, etc. This can be tricky and hard to address for contributors, and so what these commands do is implement a way to automate that. For instance, I've added a command /black so that if you leave a comment on a pull request that is just "/black" it will run black on the code, and then update the pull request. Same for /isort , which runs isort. This should lower the barrier about some of our stylistic bits that could otherwise be gatekeep-y.
On Mon, Jul 27, 2020 at 3:04 PM Matthew Turk firstname.lastname@example.org wrote:
I've issued a PR that adds a few chatops-style commands to our pull requests.
There are links in there to the issue:
which itself has a few links. Please feel free to chime in there, but I think this could make our development workflow a lot nicer -- we could stop asking people to rebase, for instance, and instead just have it done almost-automatically by a bot. And same for black, isort, etc. I'll also add a help command, now that I'm thinking of it...
Please leave feedback -- if I get some buy-in from folks I'll transfer the slash-command-processor repo to the yt-project org and then we can move forward with it a bit.
yt-dev mailing list -- email@example.com To unsubscribe send an email to firstname.lastname@example.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: email@example.com
yt-dev mailing list -- firstname.lastname@example.org To unsubscribe send an email to email@example.com https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: firstname.lastname@example.org