Hi Tomer, Sorry for the delay in replying! This sounds good. Would you like to chat early next week? We can coordinate a time to talk, and I think I'm probably the best person for it. On Sun, Oct 25, 2015 at 5:28 AM, Tomer Nussbaum <tomer.nussbaum@mail.huji.ac.il> wrote:
Hi Matthew,
Thank you for your answering. My main problem is that I know generally what code to write, but I'm not sure I get all the YT code design in this area..
So it will be great to talk to someone who knows this part of the code for 10-15 min, so I could get the basic understanding and I won't waste time on it in vain.
Thanx, Tomer
Date: Thu, 22 Oct 2015 14:49:12 -0700 From: Matthew Turk <matthewturk@gmail.com> To: "yt-dev@lists.spacepope.org" <yt-dev@lists.spacepope.org> Subject: Re: [yt-dev] Contributing to the YT project - 3D illustration - get_vertex_centered_data Message-ID: <CALO3=5GdL8zv8CK_i8hAOHRgZJk7ti+_NU4N33wjtqq6Te85Cw@mail.gmail.com> Content-Type: text/plain; charset=UTF-8
Hi Tomer,
Sorry for the long delay in replying to your email. I wanted to make sure I could collect my thoughts, and I hope you don't interpret it as not being interested in reaching out to you!
I think this is a great project. It's probably kind of hard, but certainly do-able. The changes will have to be made in the octree_subset.py section of the code, and I think they might eventually need to touch the octree handler objects inside yt/geometry/oct_container.pyx, particularly the base container.
To get started, I'd suggest just trying to do an "extrapolation" method, and then filling in from IO on disk. The technical way of doing this would be to fork the main yt repository, make a bookmark with "hg bookmark" and then push the bookmark to your repo with "hg push -B mybookmarkname" after changing the default destination in .hg/hgrc to be your fork (and leaving the main repo as something like ytanalysis). You can then commit, etc etc, and issue a PR which will get reviewed. Feel free also to issue a PR before you're done, if you'd like feedback or help during WIP.
Thanks for writing, and stop by Slack or IRC if you want to talk in more detail!
-MAtt
On Tue, Oct 20, 2015 at 7:21 AM, Tomer Nussbaum <tomer.nussbaum@mail.huji.ac.il> wrote:
Hey guys,
I wish to write the get_vertex_centered_data() function in octree_subset. and make the YT 3D illustration work also to ART and RAMSES.
So.. what is the protocol?
Thnx, Tomer
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org