On 12/02/2013 09:53 PM, Nathan Goldbaum wrote:
Here is the change:
https://bitbucket.org/ngoldbaum/yt/commits/2e6d536ffa1976e4699093c4bb3b3bc4a...
We'll definitely be leaving 'm' -> 'milli' alone. FWIW, we already do this by mapping 'mpc' -> 'Mpc' in plot labels.
That's precisely the reason it shouldn't be done this way. You're writing additional lines of code to implement workaround for invalid exception from general rules. I'd give strong -1 to the idea and additionally s/mpc/Mpc/g through out the codebase. Of course bear in mind that this comes from a person that never did simulation larger than 20kpc :P Cheers, Kacper
On Mon, Dec 2, 2013 at 3:46 PM, Britton Smith <brittonsmith@gmail.com>wrote:
Ok, then I will put my anal personality (which would never agree to such a thing) aside and say I'm cool with this.
On Mon, Dec 2, 2013 at 8:43 PM, Matthew Turk <matthewturk@gmail.com>wrote:
Hi Britton,
This would be in the units refactor of yt-3.0, and would *only* apply to parsecs. This would be the exclusive special case of m[some unit] meaning Mega.
-Matt
On Mon, Dec 2, 2013 at 3:41 PM, Britton Smith <brittonsmith@gmail.com> wrote:
Hi Matt,
Where exactly is this? Is this in yt-3.0, and if so, would this apply to all uses of m as milli? Is that is so, then my concern is for when yt becomes more used by other domains that actually do have a valid use for milli.
Britton
On Mon, Dec 2, 2013 at 8:24 PM, Matthew Turk <matthewturk@gmail.com> wrote:
Hi all,
Nathan and I are working on some unit things. One that came up is that it looked like the conversion to mpc was wrong.
Turns out, it's not. But what it's set up as is "mpc" for "milliparsecs" and "Mpc" for "Megaparsecs." We'd like to get rid of any usage of milliparsecs, since I think the number of people who want to use that (globally) are probably between 0 and 0, and just make Mpc and mpc the same thing.
If anybody objects, write back. Silence will be taken as tacit
agreement!
-Matt _______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org