Re: [yt-dev] universal_fields field names

Just a heads up to anyone interested -- most of this discussion has moved to the PR of the proposal. https://bitbucket.org/yt_analysis/ytep/pull-request/3/ytep-0003/diff On Tue, Dec 11, 2012 at 2:28 PM, Matthew Turk wrote:

Hi Casey,

On Tue, Dec 11, 2012 at 5:26 PM, Casey W. Stark wrote:

...

Cool. I submitted the PR.

So we should list all field names in the YTEP? There's also the google doc from way back.

Yes, I think so -- if you take a first pass, I can also update the PR with anything I notice, too.

PR link: https://bitbucket.org/yt_analysis/ytep/pull-request/3/ytep-0003

...

- Casey

On Tue, Dec 11, 2012 at 1:38 PM, Matthew Turk

wrote:

...

...

Hi Casey,

On Tue, Dec 11, 2012 at 4:36 PM, Casey W. Stark wrote:

...

Hi all.

I'm working on the unit system in yt-3.0 and I realized I have to

touch

...

...

a lot of the universal_fields module. I thought this might be a good time to clean up the rest of the module, since one of the 3.0 goals is to remove enzo-isms. We discussed this in a hangout and it's part of the 3.0 goals doc, but I want to get a final word before I start.

Awesome! I fully support this.

...

The idea is to make all universal field names lowercase underscored. I was not planning on changing names otherwise, but it would be a good time. This is definitely breaking compatibility, so we should get some consensus. 3.0 is a good time for this, but do we definitely want to?

I think consensus building will be crucial for this.

...

I wrote up a very small YTEP on this, but I don't have write access. Should we do pull requests for this too, or grant access as needed?

A pull request would be great. And then we should iterate on it in the PR, so that we can make sure that the field names map nicely. Does that sound alright?

Thank you for taking this on!

-Matt

...

- Casey

_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org

_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org

_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org

_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org