Hi Jared,

This is great.  Thanks for putting all of this together.

What would you think about setting up a time for you to walk us through this, and we can try to do a stage one collective review?  I'd like to try to tie this off, and if at *all* possible, verify that we either should or should *not* aim for this before 4.0, and the sooner we can make a collective decision the better, I think.

-Matt

On Tue, Feb 23, 2021 at 2:41 PM Coughlin, Jared W <jcoughl3@illinois.edu> wrote:
Hello everyone! I hope you're all doing well! 

I've been working on converting yt's test suite from nose to pytest for a while now, and I'm excited to tell everyone that it's (provisionally) done! All of the answer tests have now been converted to use pytest. All of the tests (answer and unit) run with pytest. I've also gone through and compared the results generated by nose and by pytest and compared them to one another. For the most part, the results match. There are, however, a few discrepancies (hence the aforementioned provisional completion), and I'm investigating those now (if anyone wants to help, you're more than welcome!).  Here are some links to more info if you're interested:

PR (I haven't pushed to this in a bit, but I will soon): https://github.com/yt-project/yt/pull/2817
The code I used to do the nose-pytest comparisons: https://github.com/jcoughlin11/comp_repo
The comparison failures: https://github.com/jcoughlin11/gists
A handy table showing the status of each test set: https://hackmd.io/ScakP9ELTdCxnnNEmIChMQ

Also, in addition to filling everyone in on the state of the PR, I figured now was as good a time as any to invite people who are interested to begin (again) the review process, since this is a rather large set of changes.

If you have any questions or comments, let me know! Thanks, and I hope you all have a nice day!

Sincerely,
-Jared Coughlin 
_______________________________________________
yt-dev mailing list -- yt-dev@python.org
To unsubscribe send an email to yt-dev-leave@python.org
https://mail.python.org/mailman3/lists/yt-dev.python.org/
Member address: matthewturk@gmail.com