j: Next unread message
k: Previous unread message
j a: Jump to all threads
j l: Jump to MailingList overview
New issue 582: HaloMassFunction uses Enzo ComovingBoxSize https://bitbucket.org/yt_analysis/yt/issue/582/halomassfunction-uses-enzo-co...
(reported by @mepa )
line 215, there's a reference to
self.pf["ComovingBoxSize"]. I believe this
is then converted into actual Mpc, not Mpc/h, and is then cubed to get the volume of the
I am not entirely certain, but I believe this could be replaced either by:
(self.pf.domain_width * self.pf["mpccm"]).prod()
(self.pf.domain_width * self.pf["mpc"]).prod()
depending on whether the mass function is supposed to be proper or comoving; the comments in the code suggest to me very strongly it's the first of the two, not the second.
@brittonsmith I am tagging you in the ticket, but if you aren't able to take a look at this feel free to re-assign to me.