I think this is fine. One question, looking at the patch, I don't see how the field gets the center with which to set the angular momentum. I guess it assumes it is the origin, but that is not usually the case in our simulations, where the center of a rotating star might be at a non-zero location. I know it's beyond the scope of this patch, but we might want to warn users that it assumes a particular center?

On Thu, Dec 13, 2018 at 5:38 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:

Hi all,

Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.

See https://github.com/yt-project/yt/pull/2043

I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?

If no one responds here or comments in the PR I'll probably merge the PR next week.

-Nathan
_______________________________________________
yt-dev mailing list -- yt-dev@python.org
To unsubscribe send an email to yt-dev-leave@python.org

Michael Zingale

Associate Professor

Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800

phone: 631-632-8225

e-mail: Michael.Zingale@stonybrook.edu

web: http://www.astro.sunysb.edu/mzingale

github: http://github.com/zingale