Hi Stephen, Not really... I've taken a whack at it, but I have not tested the Friends of Friends terribly well, as you suggested that was not a priority. It worked in both parallel and serial, however. I'd like to note that it seems to me there is a problem with the density output from the parallel hop; it gives different answers based on the tiling. I tested this against trunk and got the same thing. I feel like we had a fix for this that may have gotten lost. Here's my initial proposal for the combined halo finder. I've set densities in the FOF output to be -1 because I feel it is important to preserve the output between the two different formats, as they may be used as input to a unified halo profiler. http://paste.enzotools.org/show/107/ One of my test scripts can be seen here: http://hg.enzotools.org/test_scripts/file/tip/test_halo_finder.py and downloaded here: http://hg.enzotools.org/test_scripts/raw-file/17789811f400/test_halo_finder.... -Matt On Wed, Apr 22, 2009 at 12:33 PM, Stephen Skory <stephenskory@yahoo.com> wrote:
Matt,
That being said, I greatly appreciate your reluctance to break known entities. But I don't think we have to -- I'd just like to see them share a codebase, rather than a duplicated one!
Is this what you're thinking about?
http://paste.enzotools.org/show/106/
I've done a quick merge of the two files together. The differences (mainly where HOP deals with max dens stuff) have "if HOP:" and "if FoF" in front of them, which isn't functional right now but that's easily remedied.
There are a couple 'if FOF's there too.
_______________________________________________________ sskory@physics.ucsd.edu o__ Stephen Skory http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student ________________________________(_)_\(_)_______________ _______________________________________________ Yt-dev mailing list Yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org